fix(execution): settle permanent preparation rejections - #250
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Runtime can definitively reject
execution_prepareas unsupported while Core keeps retrying the same pending input until its five-minute deadline. Settle explicit configuration rejections through the existingruntime_preparation_failedpath so the Session reports a safe failure and accepts corrected input without creating a Turn.Only
invalid_configuration,unsupported_configurationandunsupported_preparationfor the currentexecution_preparerequest with no Run are terminal here. Capacity, resource pressure, unconfirmed cleanup, disconnects and unknown responses retain their existing retry/deadline behavior. The existing failure settlement checks expiration after acquiring the Session lock, before applying failure to a still-pending input. Admission and Start handling, protocol/schema, Harness adapters and MCP preparation are unchanged.Validation:
git diff --checkpassed.5d7124b060e1fe395ab1569d024c58fca47ddac4: completemake checkand daemon build, official-client acceptance, and Linux, macOS and Windows native checks all passed.This is an immediate failure-reporting fix for a bounded retry, not a claim of infinite hanging. No deployment or stored-data changes; no release is published by this PR.
The remote
make checkattempt and a supplementary test attempt overlapped on their shared test database; both encountered the exclusive execution-owner lock. The targeted rerun on a newly created isolated database passed. The clean GitHub CI run is the full-gate acceptance source; the contended remote run is not a passing result.