Skip to content

fix(mcode): use the declared environment workspace - #244

Merged
SaladDay merged 2 commits into
mainfrom
codex/mcode-declared-workspace-20260930
Sep 29, 2026
Merged

SaladDay merged 2 commits into
mainfrom
codex/mcode-declared-workspace-20260930

Conversation

@SaladDay

@SaladDay SaladDay commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

MiniMax workspace Sessions started the native process and ACP Session in the private history directory. The model consequently looked for prepared files there and wrote outputs outside the declared Environment workspace.

Use the validated Environment directory for native execution and ACP new/load, while retaining the existing Session data directory for configuration and history. This is confined to the MiniMax adapter; Core and the shared protocol are unchanged. Update the existing new/load process tests and the native workspace documentation.

Validation:

  • Linux MiniMax adapter package passed, including process cwd and ACP new/load assertions.
  • Fresh-context independent review found no actionable issues.
  • Real Linux MiniMax execution passed using a newly built daemon and the official native installer: prepared input/setup files, uploaded Skill script, Plugin MCP, and output files all use the declared workspace. After daemon stop/start, a second Turn passed with the same capability snapshot.
  • Fresh live Session: 0f92d564-6556-4859-9153-7486801cfe79; private evidence on zju: ~/.oac/acceptance/unified-environment-preparation-20260930/linux-minimax-fixed/turn-{1,2}-summary.json.
  • GitHub full check, official-client and native Linux/macOS/Windows jobs passed at 1d5f9290. MiniMax remains unsupported on Windows.
  • Remote make check passed its initial gates, then stopped at an expired external sqlc path. With the existing pinned sqlc binary, daemon/shared Go, Core/API/database, Claude and frontend build/type checks passed; the additional remote Web browser run later finished with 84 passed and two failures (overview-readiness chart visibility and Chinese wording click timeout), so its subsequent example/companion targets were not reached. No Web files changed in this PR; the exact-head full CI passed all gates. These extra remote failures are recorded rather than presented as a green remote full gate.
  • Full CI: https://github.com/MiniMax-AI/parsar-core/actions/runs/36605544715
  • Native platform CI: https://github.com/MiniMax-AI/parsar-core/actions/runs/36605544722
  • Official client CI: https://github.com/MiniMax-AI/parsar-core/actions/runs/36605544709

Existing Sessions created with the incorrect native cwd reject recovery after the cwd correction; create a new Session. Their files/history are retained. New Sessions support cold recovery. No deployment changes, history migration or data deletion.

@SaladDay
SaladDay marked this pull request as ready for review September 29, 2026 17:34
@SaladDay
SaladDay merged commit 5cac06c into main Sep 29, 2026
6 checks passed
@SaladDay
SaladDay deleted the codex/mcode-declared-workspace-20260930 branch October 7, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant