Repository navigation
feat: add optional single-host sandbox suspension - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idle hosted Sessions currently keep compute memory allocated. This adds optional microsandbox v0.7.2 suspension: after a terminal Turn and sustained inactivity with no pending work, Core captures and removes compute, then restores the next Turn in the same Session with history, files and configuration preserved. Docker remains available with its existing lifecycle. Native harness behavior is unchanged.
V1 selects exactly one provider and installation per deployment. The private setup configuration rejects provider maps and engine-based placement. A provider change requires persisted maintenance on the old installation, no unreleased instances/snapshots/uncertain operations/pending cleanup or unallocated hosted Sessions, and the incoming configuration still in maintenance. Refusal preserves resource ownership and explains the blocker. Switching does not delete resources or migrate Sessions. A separate restart with maintenance off reopens creation.
Core uses the shared five-operation sandbox API plus optional checkpoint capabilities. A pinned SDK helper owns backend operations; the existing Worker, Session lock and allocation receipts own admission and recovery. Unknown operations are observed rather than replayed, and work waits for authenticated resume.
Validation:
make checkpassed after the single-provider revision (079c07d), including all 73 Web cases, PostgreSQL tests, generated SQL checks and the Linux SDK helper.A fresh independent reviewer checked the entire diff against
fd23f169under the latest requirements and found no substantiated in-scope issues. Its focused adapter, daemon and PostgreSQL tests passed.Deployment requires Linux amd64, KVM and native Core/helper under a private service account; deploy matching daemon wire 0.5.0. Legacy retained allocations without a recorded backend identity must be cleaned through the previous Core/configuration before initial adoption. Single-sample POST-to-Turn-start latency was 27.015 seconds for creation and 21.797 seconds for resume, not a p95 or Docker speed comparison.
The current
sessionsCI run passed Go tests and reached an unchanged official-client assertion also failing on baseline fd23 and main. It still expects supportedmulti_agent.enabled=trueto be rejected. No checks were weakened; its later container step did not run. GitHubcheckandnative-buildpassed for the current revision.Design, acceptance and issue register (Document A)