Skip to content

Fix reset lost-response test failure timing #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaladDay merged 1 commit into from
Sep 28, 2026
Merged

Fix reset lost-response test failure timing #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/web/e2e/sandbox-reset.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,13 @@ test("an applied reset with a lost response stays blocked through failed reads a
await setDeployment(request, { resources: { allocations: 1, pending: 0 } });
await page.getByRole("button", { name: "Refresh sandbox state", exact: true }).click();
await expect(page.getByRole("button", { name: "Reset deployment", exact: true })).toBeEnabled();
let failReads = true;
let failReads = false;
await page.route(resetURL, async (route) => {
await route.fetch(); // Core accepted the mutation, but its response never reached this browser.
if (route.request().method() !== "POST") return route.continue();
const accepted = await route.fetch(); // Core accepted the mutation, but its response never reached this browser.
expect(accepted.ok()).toBe(true);
// Only fail reconciliation reads after acceptance; earlier reads must allow the explicit submission.
failReads = true;
await route.abort("failed");
});
await page.route(deploymentURL, (route) => failReads ? route.fulfill(unavailable) : route.continue());
Expand Down