Repository navigation
Default own-machine sandboxes to microsandbox and confirm Docker - #159
Merged
Merged
Conversation
Own machines now preselect microsandbox, marked Recommended, while a saved backend stays selected. Choosing Docker opens a confirmation listing its weaker isolation, root-equivalent docker group and limited use, with Keep microsandbox as the focused default; it asks once per wizard session and not for a saved Docker deployment. Modal gains an initialFocus option for the default action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes microsandbox the default self-hosted sandbox backend in the setup wizard. The product owner decided this; the backend's installer changes its
--sandboxdefault to match.Changes
Modalgains an optionalinitialFocus. Other dialogs are unchanged.DESIGN.mdandPRODUCT.mdare updated.docs/webneeds no change: no line there states a default.Tests
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.