Skip to content

Make sandbox fixtures match what Core sends - #155

Merged
SaladDay merged 1 commit into
mainfrom
codex/web-strict-sandbox-fixtures
Sep 26, 2026
Merged

SaladDay merged 1 commit into
mainfrom
codex/web-strict-sandbox-fixtures

Conversation

@SaladDay

@SaladDay SaladDay commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Makes the Web's sandbox test fixtures match what Core actually sends, ahead of the backend's strict runtime validation of sandbox responses in the shared client (codex/sandbox-client-projection).

Changes

  • apps/web/e2e/data/routes.mjs: removed diagnostic: "" from two seeded nodes. Core omits diagnostic while a node is ready (omitempty); it never sends an empty string.
  • apps/web/e2e/nodes.spec.ts: the inline deployment mock gains suspension: null (always serialized, null for Docker) and a 64-hex specification_digest, which is present whenever specification is.
  • apps/web/src/features/overview/test-fixtures.ts: the node() default no longer sets diagnostic: "".

Verification

  • On main: typecheck ✓, web tests 366/366, full web e2e 34/34.
  • With the backend's strict client merged in (scratch worktree):
    • agents-client 630/630, web 366/366, full web e2e 34/34.
    • All 47 captured fixture responses pass the strict projection. Before this change, the fixtures above were rejected.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

@SaladDay
SaladDay merged commit 631fc4b into main Sep 26, 2026
2 checks passed
@SaladDay
SaladDay deleted the codex/web-strict-sandbox-fixtures branch October 7, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant