Repository navigation
Retire PARSAR_NODE_ENROLLMENT_TOKEN; the node token comes only on standard input - #154
Merged
Merged
Conversation
Web's Add node command passes the token on standard input in both modes (#148), and the Core installer no longer sets the variable (#152). The node installer now refuses the variable in every mode, with a one-line message naming --enrollment-token-stdin, instead of reading it. Standard input and the hidden prompt remain. A new node without a token is told to pass it on standard input. The operations upgrade table records the retirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This retires
PARSAR_NODE_ENROLLMENT_TOKENin every mode. Web's Add node command has passed the token on standard input (--enrollment-token-stdin) since #148, and the Core installer stopped using the variable in #152.--enrollment-token-stdinand exits 2. There is no fallback.Verification
umask 077and undernohup. The manifest tests also pass.0c0341a2, the exact head, which includes mainffb4ad59. The Playwright browser cases were skipped on the server, as approved (Chrome unavailable).Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.