Repository navigation
Point the Core key hint at secrets/core.key - #150
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the console's Core key hint at the key's new location after the backend's 1b (config.json /
parsar):<install>/secrets/core.key, by default~/.parsar/core/secrets/core.key. Previously it wasadmin/core.key.Merge right after 1b, not before, so the console never shows a path that doesn't exist yet.
Changes
apps/web/src/features/first-run/ConsoleAccess.tsx: the sign-in help tip's key location.apps/web/PRODUCT.md: the same path.docs/web/core-connection.md:43-44: the same path (for the backend session's review).CORE_CONSOLE_CORE_KEY_FILEand other names are unchanged. Noadmin/core.keyremains inapps/webordocs/web.Verification
typecheck ✓, web unit tests 362/362,
access.spec.ts6/6.Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.