Repository navigation
Require enrollment_id on sandbox nodes in the client - #149
Merged
Merged
Conversation
Core always sends enrollment_id on /core/v1/sandbox/nodes list and detail reads: a string, or null for nodes enrolled before Core recorded it. The client typed it as optional only until Web's fixtures included it (#145), so SandboxNode.enrollment_id is now a required string | null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
SandboxNode.enrollment_ida requiredstring | nullinpackages/agents-client.The sandbox admin client does not validate node response shapes at runtime today, for any field, so this is enforced at compile time. A strict runtime projection for node reads, matching the admin client's other projections, is a separate follow-up.
Verification
pnpm typecheckpassed;apps/web362/362 passed.6e8efad5, the exact head including main65c4d30b, passed. The Playwright browser cases were skipped on the server (Chrome unavailable; approved skip).Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.