Skip to content

Require enrollment_id on sandbox nodes in the client - #149

Merged
SaladDay merged 1 commit into
mainfrom
codex/node-enrollment-id-required
Sep 26, 2026
Merged

SaladDay merged 1 commit into
mainfrom
codex/node-enrollment-id-required

Conversation

@SaladDay

@SaladDay SaladDay commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Makes SandboxNode.enrollment_id a required string | null in packages/agents-client.

The sandbox admin client does not validate node response shapes at runtime today, for any field, so this is enforced at compile time. A strict runtime projection for node reads, matching the admin client's other projections, is a separate follow-up.

Verification

  • agents-client typecheck and 602/602 tests passed; root pnpm typecheck passed; apps/web 362/362 passed.
  • The full local server gate on 6e8efad5, the exact head including main 65c4d30b, passed. The Playwright browser cases were skipped on the server (Chrome unavailable; approved skip).
  • Review: self-review. This is a one-line type change plus a test.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

Core always sends enrollment_id on /core/v1/sandbox/nodes list and detail
reads: a string, or null for nodes enrolled before Core recorded it. The
client typed it as optional only until Web's fixtures included it (#145), so
SandboxNode.enrollment_id is now a required string | null.
@SaladDay
SaladDay merged commit 31d9112 into main Sep 26, 2026
2 of 3 checks passed
@SaladDay
SaladDay deleted the codex/node-enrollment-id-required branch October 7, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant