Repository navigation
Show a saved Agent's model provider in the console - #137
Merged
Merged
Conversation
An Agent's detail page now has a Model provider section when the Agent saved x_agents_core.model_provider: its protocol (Anthropic Messages or OpenAI Responses), base URL, whether an API key is configured, and the context window and max output tokens when Core reports them. The read view has no key and the page never shows one. A saved Agent can have a provider and no harness, so the Agents list and the detail show "—" for a missing harness instead of "Core default". The e2e fixture adds two Production Agents, one with only a provider and one with a harness and a provider, appended after the seeded data so the rest of the demo is unchanged. One acceptance test checks that the project's Agents load, the provider-only Agent's harness reads "—", its provider section shows every field, and no key appears.
An Agent that saved no harness runs on the deployment's default harness, so "Core default" is accurate, and it matches how the page shows unset generation settings. The acceptance test now expects it for the provider-only Agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows a saved Agent's model provider in the console and guards the Agents page against the regression that #136 fixed. Real acceptance found that one Agent saved with
x_agents_core.model_providermade the whole project's Agents list fail to load ("Could not load ").Changes
model_provideris present. It lists the protocol, the base URL, and whether an API key is configured, plus the context window and max output tokens when present. The key is never read or shown.Tests
resources.spec.tsopens the project's Agents and checks:Results: typecheck ✓, unit tests 339/339, build ✓, full web e2e 23/23.
The one docs/web line,
docs/web/protocol-coverage.md:55, was reviewed by the backend session.Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.