Repository navigation
Set up sandboxes page by page - #106
Merged
Merged
Conversation
SaladDay
force-pushed
the
codex/sandbox-setup
branch
2 times, most recently
from
September 25, 2026 09:15
abdf38f to
c3ae83e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback: "这个界面还是有点太复杂了,我觉得可以做成onboarding那种一页一页的翻页效果…每个页面让用户选择的可以少一点(但是高级设置还是要在…)沙箱运行后端这里你也可以用一个问号给他们讲明白docker和microsandbox有啥区别", and "你就得在系统那儿把 sandbox 的规格也写上去吧". Builds on the #95 deployment contract.
SandboxSetupWizard, replacesSandboxSetup): where sandboxes run → Docker or microsandbox (the difference is behind a help tip) or the E2B account → the size of each sandbox (small / standard / large) → review. Large choice cards advance on a click; pages slide across; progress dashes on top. Advanced settings, one link away, hold the complete form (resources and disks, Core address, the six Runtime release fields, E2B template).resourcesandruntime, which Unify deployment sandbox configuration and node specifications #95 requires. Docker and microsandbox omit disks; microsandbox sends root and environment disks. For Docker and microsandbox, the Runtime release comes from the console's own/node-install/manifest.jsonthrough Unify Core process configuration and administrator-approved node capacity #107'sdistributionRuntime. Without a manifest, the release is entered under advanced settings.defaultSandboxResources) and this console's Runtime (distributionRuntime). E2B always needs its key again, because Core keeps no key across a change. This replaces Unify Core process configuration and administrator-approved node capacity #107's form and carries its acceptance test over to the pages.Validation: typecheck, 330 web unit tests, 13 browser acceptance tests on headless Chromium. New: own-machine setup page by page with the Runtime from the distribution. Rewritten from #107: the same backend keeps its size and Runtime, and another backend starts from its defaults (including E2B, which needs its key again).. Gate and CI results are in the checks.