Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated installer runs could reset saved settings, while interrupted downloads could overwrite the stored Compose file. The installer now preserves existing configuration by default, stages and validates updates before committing them, and verifies actual data mounts before saving newly generated secrets. Explicit installation options continue to override saved settings.
This also adds per-home installation locking, bounded downloads, failure cleanup, safe Core configuration initialization, database-aware readiness checks, and regression coverage. Operator instructions live in README; CONTRIBUTING retains the implementation contract. No product/API/schema changes or legacy runtime migration logic are included.
Validation:
make check-installerpasses on Bash 3.2 and Compose 2.15.1: existing lifecycle checks plus 17 Python regression cases. Compose parsing is real; Docker lifecycle failures are simulated.bash -n install.sh scripts/check-installer.shandgit diff --checkpass.make checkwas attempted, including a reduced-concurrency retry andmake -k checkto exercise remaining targets. It is not green: the claudecode/claudesdk Go test processes are killed, the Claude SDK exported-runtime check fails, and the native executor does not compile on macOS (OFlags::PATHand device-ID type errors). Those files are unchanged.