Fix critical security vulnerabilities and resource leaks#1
Open
Sunil56224972 wants to merge 2 commits into
Open
Fix critical security vulnerabilities and resource leaks#1Sunil56224972 wants to merge 2 commits into
Sunil56224972 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋
I was reviewing the project and found a few critical bugs and vulnerabilities. I've gone ahead and fixed them in this PR.
Summary of Fixes:
patientRecord.pyandmovement.pywhere a user could input a crafted name (e.g.,../../../filename) to overwrite arbitrary files on the system. Filenames are now safely sanitized using regex.__str__methods were manually concatenating JSON strings, making the system vulnerable to JSON injection if a name contained a double quote ("). This has been refactored to safely use Python's built-injson.dumps().res/directory did not exist, the application would hard crash with aFileNotFoundError. Addedos.makedirs(..., exist_ok=True)before file operations to ensure the directory structure exists.cv2.VideoCapturewas not released, leaving the webcam light on and the device locked. Wrapped theui.mainloop()insidemain.pywith atry...finallyblock to safely.release()the camera upon exit.Let me know if you need any changes made!