Use constant-time circular timetable arithmetic - #34
Open
A-BenLi06 wants to merge 1 commit into
Open
Conversation
A-BenLi06
marked this pull request as ready for review
August 21, 2026 09:50
A-BenLi06
force-pushed
the
perf/circular-time-arithmetic
branch
from
August 22, 2026 16:37
9818376 to
d4efc7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace iterative circular clamp/difference normalization with constant-time floor-mod arithmetic.
Problem
The existing helpers repeatedly add or subtract one period until a value reaches the requested window. Runtime is O(abs(offset) / period), so very large timetable offsets or persisted timestamps can monopolize the simulation thread. Extreme long values can also overflow while the loop is normalizing.
Change
Math.floorMod.Runtime becomes O(1) for all finite input magnitudes.
Validation
./gradlew test --no-daemonPart of #32.