Fix: Missing code elements (await, closing paren, variable declaration)#270
Open
qiutongMS wants to merge 1 commit into
Open
Fix: Missing code elements (await, closing paren, variable declaration)#270qiutongMS wants to merge 1 commit into
qiutongMS wants to merge 1 commit into
Conversation
…e declaration) - Add missing await on LanguageModel.CreateAsync() in phi-silica-lora.md - Fix missing closing parenthesis on TryEnqueue call in initialize-execution-providers.md - Add missing experimentalModel declaration in phi-silica-structured-output.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing code syntax elements that prevent compilation in 3 documentation pages.
Changes
docs/apis/phi-silica-lora.md - Added missing
awaitonLanguageModel.CreateAsync(). Without it,sessionis anIAsyncOperation<LanguageModel>instead of aLanguageModel.docs/new-windows-ml/initialize-execution-providers.md - Fixed missing closing parenthesis on
TryEnqueue()call. Changed};to});.docs/apis/phi-silica-structured-output.md - Added missing
var experimentalModel = new LanguageModelExperimental(languageModel);declaration. The C# code usedexperimentalModelwithout declaring it (the C++ tab had the equivalent line).Validation