Skip to content

Allow empty or null options in presets#16

Merged
loicsapone merged 1 commit into
Mezcalito:0.xfrom
LocService:fix/allow-falsy-options
Jan 13, 2026
Merged

Allow empty or null options in presets#16
loicsapone merged 1 commit into
Mezcalito:0.xfrom
LocService:fix/allow-falsy-options

Conversation

@ls-gurvan

@ls-gurvan ls-gurvan commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Description

Allows presets to be defined without options or with empty/null options values, providing more flexibility in preset configuration.

Changes

  • Resolver handles falsy option values by normalizing them to empty arrays

Testing

Added comprehensive tests covering three scenarios:

  • Preset without options key
  • Preset with empty options array
  • Preset with null options value

All three cases produce identical results, ensuring consistent behavior regardless of how "no options" is expressed.

@ls-gurvan ls-gurvan marked this pull request as draft January 12, 2026 11:16
@ls-gurvan ls-gurvan marked this pull request as ready for review January 12, 2026 11:33
@loicsapone loicsapone merged commit 2792d0b into Mezcalito:0.x Jan 13, 2026
7 checks passed
@loicsapone

Copy link
Copy Markdown
Member

Thanks @ls-gurvan!

@mdanet-gobocom

Copy link
Copy Markdown
Contributor

Hi @loicsapone ,
Do you plan to release the fix soon ?

@ls-gurvan ls-gurvan deleted the fix/allow-falsy-options branch January 19, 2026 08:11
@loicsapone

Copy link
Copy Markdown
Member

Hi @mdanet-gobocom, it's done!
https://github.com/Mezcalito/imgproxy-bundle/releases/tag/0.5.2

@mdanet-gobocom

Copy link
Copy Markdown
Contributor

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants