Skip to content

Patches and lint/format error catching. Explicitly adding zod and altering toggle component.#488

Merged
bapplejax merged 6 commits into
mainfrom
patching-05-01-2026
May 1, 2026
Merged

Patches and lint/format error catching. Explicitly adding zod and altering toggle component.#488
bapplejax merged 6 commits into
mainfrom
patching-05-01-2026

Conversation

@bapplejax

@bapplejax bapplejax commented May 1, 2026

Copy link
Copy Markdown
Contributor

Description

Updating many packages
image

Changing toggle component to pass lint and formatter
Adding zod to devDependencies.

How Has This Been Tested?

Build scripts all ran.

Screenshots (if appropriate):

image

@bapplejax bapplejax self-assigned this May 1, 2026
Copilot AI review requested due to automatic review settings May 1, 2026 16:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates tooling/dependencies and adjusts the Toggle component implementation (plus stories/tests) to satisfy lint/format requirements while improving controlled vs uncontrolled behavior.

Changes:

  • Bump multiple devDependencies (Storybook, Vitest, Prettier, etc.) and add zod-validation-error.
  • Refactor Toggle to support controlled (checked provided) and uncontrolled (checked omitted) usage without useEffect.
  • Update Toggle unit tests and Storybook stories to align with the new Toggle behavior.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/comet-extras/tsconfig.json Formatting-only fix to JSON structure/indentation.
packages/comet-extras/src/components/toggle/toggle.tsx Refactors toggle state handling to support controlled/uncontrolled usage and removes useEffect.
packages/comet-extras/src/components/toggle/toggle.test.tsx Expands/adjusts tests for controlled vs uncontrolled behavior and checked rendering.
packages/comet-extras/src/components/toggle/toggle.stories.tsx Updates stories to better demonstrate uncontrolled and controlled usage patterns.
package.json Updates many devDependencies and adds zod-validation-error.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
"typescript": "6.0.3",
"typescript-eslint": "^8.59.1",
"vite": "^8.0.10",
"vitest": "^4.1.5",
@codecov

codecov Bot commented May 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.59%. Comparing base (70a758b) to head (d1d331b).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          51       51           
  Lines         995      995           
  Branches      344      345    +1     
=======================================
  Hits          991      991           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bapplejax bapplejax merged commit 85a8d6e into main May 1, 2026
10 checks passed
@bapplejax bapplejax deleted the patching-05-01-2026 branch May 1, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants