Patches and lint/format error catching. Explicitly adding zod and altering toggle component.#488
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates tooling/dependencies and adjusts the Toggle component implementation (plus stories/tests) to satisfy lint/format requirements while improving controlled vs uncontrolled behavior.
Changes:
- Bump multiple devDependencies (Storybook, Vitest, Prettier, etc.) and add
zod-validation-error. - Refactor
Toggleto support controlled (checkedprovided) and uncontrolled (checkedomitted) usage withoutuseEffect. - Update Toggle unit tests and Storybook stories to align with the new Toggle behavior.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/comet-extras/tsconfig.json | Formatting-only fix to JSON structure/indentation. |
| packages/comet-extras/src/components/toggle/toggle.tsx | Refactors toggle state handling to support controlled/uncontrolled usage and removes useEffect. |
| packages/comet-extras/src/components/toggle/toggle.test.tsx | Expands/adjusts tests for controlled vs uncontrolled behavior and checked rendering. |
| packages/comet-extras/src/components/toggle/toggle.stories.tsx | Updates stories to better demonstrate uncontrolled and controlled usage patterns. |
| package.json | Updates many devDependencies and adds zod-validation-error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "typescript": "6.0.3", | ||
| "typescript-eslint": "^8.59.1", | ||
| "vite": "^8.0.10", | ||
| "vitest": "^4.1.5", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 51 51
Lines 995 995
Branches 344 345 +1
=======================================
Hits 991 991
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sketch0395
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating many packages

Changing toggle component to pass lint and formatter
Adding zod to devDependencies.
How Has This Been Tested?
Build scripts all ran.
Screenshots (if appropriate):