feat(auto-fish): add offhand fishing rod support - #6653
Open
Big-Iron-Cheems wants to merge 5 commits into
Open
Conversation
Contributor
|
it won't work; it'll just reel in the first rod. |
Collaborator
Author
|
Reminder: preserve the existing auto-switch behavior while adding offhand support. Currently The intended behavior should remain that Also, |
Select the highest-scoring usable rod from the hotbar and offhand when casting or reeling. Preserve selected-hotbar-first tie-breaking and respect auto-switch and anti-break behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Refactors
AutoFishto use an explicit state machine for managing the fishing lifecycle.The previous implementation tracked the fishing lifecycle through
wasHookedand several conditional checks.This change introduces explicit
IDLE,WAITING_FOR_BITE, andWAITING_TO_REELstates, making the module's behavior easier to follow and maintain.Adds support for fishing rods in the offhand and resolves which hand currently contains a usable rod when casting or reeling.
This also handles moving the rod between the main hand and offhand while fishing.
The existing fishing behavior is preserved, including cast/catch delays, anti-break handling, automatic rod switching, and automatic recasting.
Related issues
N/A
How Has This Been Tested?
Tested in-game to verify that:
Checklist: