Repository navigation
fix: add src/evalml/leadtimes.py, missing from #272 - #291
Closed
Louis-Frey wants to merge 1 commit into
Closed
Louis-Frey wants to merge 1 commit into
Louis-Frey wants to merge 1 commit into
Conversation
#272 moved resolve_leadtimes (and PARAMS_WITHOUT_STEP_ZERO_VALUE) out of workflow/rules/common.smk and imports them from evalml.leadtimes, but the module was not committed. Every workflow now fails at startup with ModuleNotFoundError. Restore it with the code removed from common.smk in #272. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#272 moved
resolve_leadtimesandPARAMS_WITHOUT_STEP_ZERO_VALUEout ofworkflow/rules/common.smkand imports them withfrom evalml.leadtimes import resolve_leadtimes, butsrc/evalml/leadtimes.pywas not part of the commit. Since then every workflow onmainfails at startup:This PR adds the module with exactly the code #272 removed from
common.smk(taken from36da75b, the parent of #272), plus theloggingandreimports it needs.If you have the original file locally, feel free to push it instead and close this PR.
Checks:
evalml experiment config/forecasters-ich1-oper.yaml -- --dry-runplans 25 jobs with the fix and fails with the error above without it.pytest tests/unit: 289 passed.ruff checkandruff format --checkpass.