fix: Validate date after duration offset - #4124
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4124 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 429 429
Lines 12495 12497 +2
Branches 1976 1976
=======================================
+ Hits 12320 12322 +2
Misses 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MajorLift
reviewed
Sep 17, 2026
| if (duration.isValid) { | ||
| // This ensures the duration is at least 1 second. | ||
| const validatedDuration = getDuration(duration); | ||
| const offsetDate = DateTime.now().toUTC().plus(validatedDuration); |
Contributor
There was a problem hiding this comment.
What do you think about triggering a type error as well with something like:
import { DateTime, Duration } from 'luxon';
+import type { DateTimeMaybeValid } from 'luxon';
+/**
+ * Add a duration to the current time. The sum may fall outside the
+ * representable date range, so the result may be invalid.
+ *
+ * @param duration - The duration to add.
+ * @returns The resulting date, which may be invalid.
+ */
+function getOffsetDate(duration: Duration<true>): DateTimeMaybeValid {
+ return DateTime.now().toUTC().plus(duration);
+}
+
/**
* Get the next execution date from a schedule, which should be either:
- const offsetDate = DateTime.now().toUTC().plus(validatedDuration);
+ const offsetDate = getOffsetDate(validatedDuration);
FrederikBolding
marked this pull request as ready for review
September 18, 2026 07:41
Mrtenz
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cronjob execution dates configured using durations can technically overflow and cause unexpected behaviour. We can catch this by asserting
isValid.Note
Low Risk
Small change to cron schedule parsing with clearer errors on edge-case durations; no auth or data-path changes.
Overview
Cronjob scheduling now rejects ISO 8601 durations that produce an invalid execution time after adding them to “now”, instead of returning a bad date.
Duration handling in
getExecutionDateis folded into the sametry/catchas cron parsing. AfterDateTime.now().plus(validatedDuration), anassert(offsetDate.isValid)runs so overflow cases (e.g.P1000000Y) fail with the existing “Unable to parse …” error. A test covers that extreme duration.Reviewed by Cursor Bugbot for commit 13cd74c. Bugbot is set up for automated code reviews on this repo. Configure here.