refactor(snaps-rpc-methods)!: Use messenger for permitted methods#3987
Draft
FrederikBolding wants to merge 11 commits intofb/restricted-methods-messengerfrom
Draft
refactor(snaps-rpc-methods)!: Use messenger for permitted methods#3987FrederikBolding wants to merge 11 commits intofb/restricted-methods-messengerfrom
FrederikBolding wants to merge 11 commits intofb/restricted-methods-messengerfrom
Conversation
FrederikBolding
commented
May 6, 2026
| /** | ||
| * @returns All installed Snaps. | ||
| */ | ||
| getAllSnaps: () => Promise<GetSnapsResult>; |
Member
Author
There was a problem hiding this comment.
Turns out the types here have always been wrong
FrederikBolding
commented
May 6, 2026
| * file does not exist. | ||
| */ | ||
| export type GetFileResult = string; | ||
| export type GetFileResult = string | null; |
Member
Author
There was a problem hiding this comment.
This has always been possible, but the type was wrong.
FrederikBolding
changed the base branch from
main
to
fb/restricted-methods-messenger
FrederikBolding
force-pushed
the
fb/refactor-permitted-methods
branch
from
41732f0 to
84d1229
Compare
FrederikBolding
changed the title
FrederikBolding
commented
May 7, 2026
| import { updateInterfaceHandler } from './updateInterface'; | ||
|
|
||
| /* eslint-disable @typescript-eslint/naming-convention */ | ||
| const methodHandlers = { |
Member
Author
There was a problem hiding this comment.
TypeScript failed to generate declarations for this, but we don't actually need to export it, so I moved it here and stopped exporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the permitted method handlers to use the
messengerwhere applicable.https://consensyssoftware.atlassian.net/browse/WPC-995