Conversation
…d drop a stale-closure example
…ing a value the effect uses
It was stated only as an effects rule, and the cost it names is a compiler cost: an entry the effect never reads makes the compiler skip the whole function, so the hook ships unmemoized. Someone asking what loses them compiler coverage opens the compiler overlay, where the rule was absent. Zero hits for it across all four react-compiler surfaces before this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folded into #170, which now carries these four commits alongside the mobile React Compiler references.
Closing this one. The branch
jongsun/add/hooks-effects-restart-keys-and-protocolsis left in place and is no longer the source of truth for this content.