Conversation
matallui
force-pushed
the
fix/performance-skill-description-over-1024
branch
2 times, most recently
from
September 15, 2026 15:26
57f11b1 to
e885ac9
Compare
The pi coding agent (v0.85.1) warns about any skill whose description exceeds 1024 characters at startup — the base performance skill (1078 chars) triggers "[Skill conflicts] description exceeds 1024 characters (1078)" on every launch. The skill still loads (pi treats this as a validation warning, not a rejection), but the warning names a file we ship, so keep our descriptions within the limit. - Trim the performance skill description from 1078 to 949 characters, keeping every trigger cue (slow/laggy/janky surfaces, re-renders, memoization, FlashList, Reanimated, TTI, bundle size, cpuprofile, render-regression tests, and the exclusions). - Trim the swaps-cpu-profile-audit description from 1411 to 893 characters, which also tripped the warning in pi. - Lower DESCRIPTION_MAX to 1024, the strictest operator's validation limit, so the linter blocks descriptions that trip operator warnings, and update the schema comment, README, CONTRIBUTING, and skill template to state the new number and cite the operator. Cite-the-operator evidence requested by the schema comment: pi coding agent v0.85.1, docs/skills.md — Validation section: over-limit descriptions "produce warnings but still load the skill".
…-description-over-1024 * origin/main: feat: add navigation skill with MetaMask Mobile overlay (#148) feat: add feature-flags skill with MetaMask Mobile overlay (#147) feat: add analytics skill with MetaMask Mobile overlay (#140) feat: Adds `observability` domain with Sentry, Tempo, telemetry cost control skills (#76) refactor(perps): review skill composes the perps library instead of carrying knowledge copies (#159) # Conflicts: # README.md
matallui
force-pushed
the
fix/performance-skill-description-over-1024
branch
from
September 15, 2026 15:27
e885ac9 to
9bb8561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pi coding agent (v0.85.1) warns about any skill whose
descriptionexceeds 1024 characters at startup. The baseperformanceskill is 1078 characters, so every pi user sees this on launch:The skill still loads — pi treats this as a validation warning, not a rejection (its Validation docs: over-limit descriptions "produce warnings but still load the skill"; only missing/empty descriptions and malformed
SKILL.mdfiles fail to load). But the warning names a file we ship, so our descriptions should fit the limit.This PR:
performanceskill description from 1078 to 949 characters. Every trigger cue is kept — slow/laggy/janky surfaces, re-renders, memoization, FlashList, Reanimated, TTI, bundle size,.cpuprofile/Release Profiler analysis, render-regression tests, and the "not for" exclusions. The only cuts are filler ("at any stage", "and wanting to avoid perf pitfalls before building"), a redundant example filename, and a phrase duplicating the Release Profiler mention.swaps-cpu-profile-auditdescription from 1411 to 893 characters. It passed the old budget but was equally warning-worthy in pi.DESCRIPTION_MAXfrom 1536 to 1024 soyarn audit:skillsblocks descriptions that trip operator warnings, and updates the schema comment, README, CONTRIBUTING, and skill template accordingly.On point 3: the schema comment asks contributors to "cite the operator and version before claiming any figure is externally imposed" — citation: pi coding agent v0.85.1,
docs/skills.md: thedescriptionfield is "Max 1024 chars", and the Validation section states over-limit descriptions "produce warnings but still load the skill". So 1024 is the largest value that trips no operator's validation — exactly what CONTRIBUTING's "lowest limit across operators" already assumes.Type of Change
Skill Details (if adding a new skill)
N/A — existing skills only.
Checklist
Testing
yarn audit:skills→ 63 skill(s) checked, 0 errors (96 warnings are pre-existing on main)yarn test→ 71/71 pass, including the docs-state/enforced-ceiling consistency test, which asserts 1024yarn lint:changelog→ cleantype: "warning"diagnostics and the skill object is still returned and loaded; the[Skill conflicts]banner is warning-colored. Reproduced locally: pi reports[Skill conflicts] description exceeds 1024 characters (1078)for the unmodified skill while it remains loaded; after this change the description parses clean.