Conversation
`metrametrics-identity` and `segment-governance`, split out of the domain that was called `analytics` and is becoming `observability` in #76. Traces, errors and span cost are one subject; product analytics is another, and with MetaMetrics migrating to `AnalyticsController` in both clients this half needs a name that outlives the tool. Knowledge only, no skill yet. `tools/install` copies domain knowledge beside each skill in its domain, so nothing here installs until the domain gains one — stated in the body rather than discovered at install time.
MajorLift
changed the title
data domain for product-analytics knowledgedata domain - product-analytics knowledge
… `main` The file quoted an `isOptIn` branch in `MetaMetricsController` that metamask-extension#42885 (integrate analytics controller) removed. Anonymity is now set per event by `excludeMetaMetricsId`, including a default for event names starting with `Send` or `Confirm`, and read by the platform adapter. Citations are pinned to extension `c31416a`.
`@metamask/analytics-controller` sends it once identified without them and once anonymous with them, so a count over both rows counts it twice. The analytics ID is a hex string rather than a UUIDv4, and Sentry carries the same value as `user.id`.
… to every `platform` skill
MajorLift
changed the title
data domain - product-analytics knowledgemetamask-extension overlay for analytics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The extension's MetaMetrics and Segment event guidance sits in
observability/instrumentation, which a) cites two knowledge files in adatadomain that does not exist, and b) overlapsplatform/analytics, which also covers tracked events but has nometamask-extensionoverlay and so is skipped for Extension.Overview
Adds a
metamask-extensionoverlay to theanalyticsskill and two knowledge files to theplatformdomain, and moves event guidance out ofobservability/instrumentation.analyticsgains ametamask-extensionoverlay for tracking events throughuseAnalytics, the backgroundtrackEventandcreateEventBuilder, and the Redux thunktrackAnalyticsEvent, covering adding and updating an event, tests, and a review ofexcludeMetaMetricsId. Its description now names MetaMetrics and Segment events, and its base workflow no longer names the MetaMask Mobile catalog (EVENT_NAME,generateOpt), test factory or Engine tracking util.domains/platform/knowledge/metametrics-identity.md: which extension MetaMetrics events are sent without the user's analytics ID.domains/platform/knowledge/segment-governance.md: Segment event governance, which is advisory. An event is meant to be registered in the tracking plan kept inConsensys/segment-schema(internal to Consensys), and ate81ed46nometamask-extensionworkflow checks an event against that plan.instrumentationnow covers Sentry spans and volume estimation from Sentry span data, and its Do Not Use When list namesanalyticsfor MetaMetrics and Segment events.sentry-quotanamesanalyticsfor product-analytics events in its Do Not Use When list, and its three citations ofsegment-governance.mdnow point to theplatformdomain instead of the missingdatadomain.Both files are copied beside each
platformskill an install selects:analyticsformetamask-extension, andanalytics,feature-flagsandnavigationformetamask-mobile, although both describe only the extension.