Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messagepayloads before destructuringevent.datainwindowPostMessageTransportpostMessageevents withnulland primitive payloadsFixes #108.
Testing
./node_modules/.bin/vitest.cmd run src/transports/windowPostMessageTransport.test.ts./node_modules/.bin/biome.cmd check src/transports/windowPostMessageTransport.ts src/transports/windowPostMessageTransport.test.tsNote
Low Risk
Narrow defensive guard on message filtering with a targeted unit test; no changes to request/response or auth flows.
Overview
Fixes crashes when unrelated
window.postMessagetraffic uses null or primitiveevent.datavalues. The listener inwindowPostMessageTransportnow returns early unlessevent.datais a non-null object, before destructuringtargetanddata.A regression test asserts that
nulland string payloads are ignored without throwing, matching behavior for wrong origin, target, or stream name.Reviewed by Cursor Bugbot for commit 8a4e694. Bugbot is set up for automated code reviews on this repo. Configure here.