feat(engine): wire NeoBankService for Money Account onboarding

[roz0n]

Description

Wires NeoBankService from @metamask/ramps-controller into the Mobile Engine, and moves the RampsController messenger onto the package-owned list of required controller actions.

Why: Money Account onboarding needs to reach the neo-bank API (autoramp lookup, MoonPay customer resolution, self-hosted wallet registration), and the RampsController onboarding stage lookup needs access to the controller actions the package declares it depends on. Neither was available on Mobile.

What changed:

• NeoBankService is registered as a stateless service. A new neo-bank-service-init.ts constructs it the same way TransakService is — sharing getRampsEnvironment() / getRampsContext() and the global fetch. The service is added to the Engine init map and context, STATELESS_NON_CONTROLLER_NAMES, MESSENGER_FACTORIES, and the MessengerClients / MessengerClientsToInitialize types.
• New getNeoBankServiceMessenger. Delegates AuthenticationController:getBearerToken so the service can authenticate its requests.
• NeoBankServiceActions / NeoBankServiceEvents are now unioned into GlobalActions / GlobalEvents next to the other ramps entries, alongside the NeoBankService class import they belong to.
• getRampsControllerMessenger spreads RAMPS_CONTROLLER_REQUIRED_CONTROLLER_ACTIONS in addition to the existing RAMPS_CONTROLLER_REQUIRED_SERVICE_ACTIONS. The hand-maintained RemoteFeatureFlagController:getState delegate is dropped because that action is already a member of the package-owned list — spreading it means the KYC/customer actions the onboarding stage lookup will need (from MetaMask/core#10116) arrive automatically on the next @metamask/ramps-controller bump instead of silently going missing.
• Tests cover neoBankServiceInit, getNeoBankServiceMessenger, and pin that RemoteFeatureFlagController:getState remains delegated via the package-owned controller-actions list.

Scope note: this branch originally also carried the KYC controller wiring and the React Native SumSub launcher. Those have since landed on main via #35540 and #36081, so they no longer appear in this diff. What remains is the NeoBankService wiring and the ramps messenger permission change.

Follow-up: RAMPS_CONTROLLER_REQUIRED_CONTROLLER_ACTIONS in the currently resolved @metamask/ramps-controller@20.3.0 is ['AuthenticationController:getSessionProfile', 'KeyringController:signPersonalMessage', 'RemoteFeatureFlagController:getState']. The KYC-facing additions land with MetaMask/core#10116; no dependency bump is required for this PR to compile and behave correctly today.

Changelog

CHANGELOG entry: Added NeoBankService Engine wiring for Money Account onboarding

Related issues

Partially completes: https://consensyssoftware.atlassian.net/browse/TRAM-3900

Manual testing steps

Feature: NeoBankService wired into the Mobile Engine

  Scenario: Engine exposes the neo-bank service at startup
    Given the app has a persisted wallet
    When the app launches and Engine initializes
    Then Engine.context.NeoBankService is defined
    And no messenger delegation errors are logged during Engine init

  Scenario: Ramps quotes are unaffected by the messenger permission change
    Given a signed-in user on a build with the moneyHeadlessAllProviders feature flag enabled
    When the user opens Buy and requests quotes
    Then RampsController still reads the feature flag and widens quotes as before
    And no "Action missing from allow list: RemoteFeatureFlagController:getState" error is thrown

Screenshots/Recordings

Before

N/A — Engine wiring only, no UI surface in this PR.

After

N/A — Engine wiring only, no UI surface in this PR.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
• I've tested with a power user scenario
• I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches Engine startup and ramps messenger allow-lists used for buy/onboarding flows, including auth token delegation for external neo-bank APIs; regressions would surface as init or quote/onboarding failures rather than data loss.

Overview
Registers NeoBankService on the Mobile Engine so Money Account onboarding can call the neo-bank API. A new init module constructs the service like TransakService (shared ramps environment/context, global fetch), exposes it on Engine.context, and adds messenger wiring that delegates AuthenticationController:getBearerToken for authenticated API calls.

Updates RampsController messenger permissions by spreading RAMPS_CONTROLLER_REQUIRED_CONTROLLER_ACTIONS from @metamask/ramps-controller alongside the existing required service actions, replacing the hand-maintained RemoteFeatureFlagController:getState entry so package upgrades pick up new dependencies (including future onboarding/KYC actions) without silent gaps.

Tests cover service init, neo-bank messenger delegation, and that ramps-controller delegates all package-declared required actions without duplicates.

^{Reviewed by Cursor Bugbot for commit 53c66f8. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

[codecov-commenter]

Codecov Report

❌ Patch coverage is 93.22034% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.00%. Comparing base (1cce8cd) to head (c787d07).
⚠️ Report is 60 commits behind head on main.

Files with missing lines	Patch %	Lines
...iews/VirtualBankAccount/hooks/useKycDisclaimers.ts	92.85%	1 Missing and 1 partial ⚠️
...ngine/controllers/kyc/reactNativeSumSubLauncher.ts	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #35896      +/-   ##
==========================================
+ Coverage   85.96%   86.00%   +0.04%     
==========================================
  Files        6859     6886      +27     
  Lines      192237   192854     +617     
  Branches    47836    47991     +155     
==========================================
+ Hits       165265   165873     +608     
+ Misses      16261    16249      -12     
- Partials    10711    10732      +21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 25cc449. Configure here.}

[cursor]

Ramps messenger drops feature-flag action

High Severity

getRampsControllerMessenger no longer delegates RemoteFeatureFlagController:getState. RampsController still reads moneyHeadlessAllProviders through that action on each quote. Without the delegate, the check fails closed and quote widening stays native-only, so aggregator and WebView deposit providers stay hidden even when the flag is on.

 

^{Reviewed by Cursor Bugbot for commit 25cc449. Configure here.}

[roz0n]

False positive — no production fix needed.

RemoteFeatureFlagController:getState is still delegated. This PR only removed the hand-maintained duplicate; the same action is already a member of RAMPS_CONTROLLER_REQUIRED_CONTROLLER_ACTIONS, which getRampsControllerMessenger now spreads.

Verified against the resolved @metamask/ramps-controller@20.3.0:

RAMPS_CONTROLLER_REQUIRED_CONTROLLER_ACTIONS = [
  'AuthenticationController:getSessionProfile',
  'KeyringController:signPersonalMessage',
  'RemoteFeatureFlagController:getState',
]

Pinned in ramps-controller-messenger.test.ts so a future package bump that drops the action from that list fails CI instead of silently breaking quote widening.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps, SmokeMMConnect
• Selected Performance tags: @PerformanceMoney
• Risk Level: high
• AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (global-infrastructure-change): Global infrastructure changed: app/core/Engine/Engine.ts. Running all tests.

Performance Test Selection:
The NeoBankService is integrated into the Engine initialization pipeline and is specifically for Money Account (neo-bank) onboarding. The @PerformanceMoney tag covers Money Home balance and activity content loading. Since NeoBankService is now initialized as part of Engine startup, it could potentially impact Money Account loading performance. The ramps-controller-messenger changes also affect the RampsController's delegated actions which powers the Money Account flows. However, since this is an additive service initialization (stateless, no state management), the performance impact is expected to be minimal.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[metamask-ci]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[github-actions]

⚡ Performance Test Results

ℹ️ Performance test results are currently non-blocking and will not block this PR.

✅ All tests passed · 2 tests · 1 device

📱 Devices tested (1)

Android: Google Pixel 8 Pro (v14.0)

✅ Passed Tests (2)

Test	Platform	Device	Duration	Team	Recording
Money Home after importing SRP with funded balance	Android	Google Pixel 8 Pro (v14.0)	3.83s	@mm-earn-team	📹 Watch
Money Home after fresh wallet creation with empty balance	Android	Google Pixel 8 Pro (v14.0)	19.96s	@mm-earn-team	📹 Watch

---

Branch: feat/TRAM-3922-kyc-engine-wiring · Build: E2E · Commit: b9527d5 · View full run