Skip to content

feat: Cover with E2E tests a scenario when user opens phishing websites or websites that load these phishing websites via iFrame#16714

Closed
Tyschenko wants to merge 7 commits into
mainfrom
feature/iframe_malicious_url_detection_e2e_tests
Closed

feat: Cover with E2E tests a scenario when user opens phishing websites or websites that load these phishing websites via iFrame#16714
Tyschenko wants to merge 7 commits into
mainfrom
feature/iframe_malicious_url_detection_e2e_tests

Conversation

@Tyschenko

Copy link
Copy Markdown
Contributor

E2E tests for the changes #16706

Description

Issue: https://github.com/MetaMask/mobile-planning/issues/2227

We currently have an anti-fishing warning which is displayed when user opens a malicious website.
But there is a way to bypass this warning if you load a malicious website via iFrame.

Example of the malicious website: https://coin-qr.to/
Example of the website with a malicious iFrame: https://lol-au4.pages.dev/cb (opens coin-qr.to inside in the iFrame)
We can inject a JS script in the mobile browser that will check webpage's iFrames and report their URLs to the browser in MetaMask mobile app.Issue: https://github.com/MetaMask/mobile-planning/issues/2227

We currently have an anti-fishing warning which is displayed when user opens a malicious website.
But there is a way to bypass this warning if you load a malicious website via iFrame.

Example of the malicious website: https://coin-qr.to/
Example of the website with a malicious iFrame: https://lol-au4.pages.dev/cb (opens coin-qr.to inside in the iFrame)
We can inject a JS script in the mobile browser that will check webpage's iFrames and report their URLs to the browser in MetaMask mobile app.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Tyschenko Tyschenko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team Run Smoke E2E labels Jun 26, 2025
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 26, 2025
@github-actions

github-actions Bot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f46d98ad89455b204be48037a75114aa39e7d0d5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d37e8b53-977a-41c0-bafc-202e4b1bf25d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Tyschenko Tyschenko force-pushed the feature/iframe_malicious_url_detection_e2e_tests branch from f46d98a to 546a21b Compare June 26, 2025 14:53
@Tyschenko Tyschenko force-pushed the feature/iframe_malicious_url_detection branch from 60d2854 to efa4fd5 Compare July 21, 2025 09:49
@Tyschenko Tyschenko force-pushed the feature/iframe_malicious_url_detection_e2e_tests branch from 6d539aa to 3b3ce2a Compare July 21, 2025 11:04
@sonarqubecloud

Copy link
Copy Markdown

Base automatically changed from feature/iframe_malicious_url_detection to main July 21, 2025 15:52
@Tyschenko Tyschenko closed this Jul 31, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants