release(runway): cherry-pick fix(ci): restrict AMO flask/production to release/*; block flask dispatch - #45326
Merged
sleepytanya merged 1 commit intoAug 7, 2026
Conversation
…o release/*; block flask dispatch (#45302) ## **Description** Align AMO **production** and **flask** to **`release/*` only** (not `main`) so uploads use the same workflow version as the cut. Flask remains orchestrator-only: `flask` is removed from `workflow_dispatch` target options, and the sender check rejects any human/non-Runway flask dispatch. Do **not** gate on `github.event_name` — in a reusable workflow that value is the caller's trigger, so a Runway orchestrator `workflow_call` (itself `workflow_dispatch`) would falsely fail. Keep `workflow_call` for Runway Phase 3. **Companion:** [infra PR #19](https://github.com/consensys-vertical-apps/va-mmc-extension-submission-infra/pull/19) (`amo-submission-flask` + `amo-submission-production` OIDC `release/*` only). Docs: [releases#32](https://github.com/MetaMask/releases/pull/32). **GitHub Environment config (done):** - [x] Remove required reviewers on `amo-flask` - [x] Set `amo-flask` and `amo-production` deployment branches to **`release/*` only** (remove `main`) ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: INFRA-3769 ## **Manual testing steps** 1. On `release/X.Y.Z`, Actions → Upload extension to Firefox AMO — targets are `production` and `dev` only (`flask` not offered). 2. `target=production` on `release/*` passes the branch guard (then waits on `amo-production` approval). 3. `target=production` on `main` fails the branch guard. 4. Orchestrator `workflow_call` with `target=flask` still succeeds (sender = Runway; no env reviewers on `amo-flask`). 5. Human attempt at flask (API/`workflow_call` from a user) fails the sender check before AWS creds. ## **Screenshots/Recordings** N/A ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sleepytanya
approved these changes
Aug 7, 2026
sleepytanya
enabled auto-merge (squash)
August 7, 2026 17:17
|
Contributor
|
No release label on PR. Adding release label release-13.43.0 on PR, as PR was cherry-picked in branch 13.43.0. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Align AMO production and flask to
release/*only (notmain) so uploads use the same workflow version as the cut.Flask remains orchestrator-only:
flaskis removed fromworkflow_dispatchtarget options, and the sender check rejects anyhuman/non-Runway flask dispatch. Do not gate on
github.event_name— in a reusable workflow that value is the caller's trigger, so a Runway
orchestrator
workflow_call(itselfworkflow_dispatch) would falselyfail. Keep
workflow_callfor Runway Phase 3.Companion: infra PR
#19
(
amo-submission-flask+amo-submission-productionOIDCrelease/*only). Docs:
releases#32.
GitHub Environment config (done):
amo-flaskamo-flaskandamo-productiondeployment branches torelease/*only (removemain)Changelog
CHANGELOG entry: null
Related issues
Fixes: INFRA-3769
Manual testing steps
release/X.Y.Z, Actions → Upload extension to Firefox AMO —targets are
productionanddevonly (flasknot offered).target=productiononrelease/*passes the branch guard (thenwaits on
amo-productionapproval).target=productiononmainfails the branch guard.workflow_callwithtarget=flaskstill succeeds(sender = Runway; no env reviewers on
amo-flask).workflow_callfrom a user) fails thesender check before AWS creds.
Screenshots/Recordings
N/A
Before
N/A
After
N/A
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Co-authored-by: Cursor cursoragent@cursor.com bc18c5c