release(runway): cherry-pick feat: added timer for balance loading - #45049
Merged
Merged
Conversation
This PR is to add timeout to the balance loading state <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null Fixes: 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > UI-only loading-state timing in wallet overview; no auth, data, or payment logic. > > **Overview** > **Wallet overview** no longer keeps the balance skeleton up indefinitely when the account has on-chain balance but aggregate fiat is still **$0** (e.g. rates still loading). > > `coin-overview` adds a **1.5s** timer (`ZERO_FIAT_BALANCE_DELAY_MS`): the loading skeleton only applies while `shouldDelayZeroFiatBalance` is true **and** the delay has not elapsed. After the timeout, the normal balance UI is shown instead of staying on the skeleton. The timer **restarts** when enabled networks change (stable key from `enabledNetworks`). > > `eth-overview.test.js` asserts the skeleton disappears after 1500ms (fake timers) and resets real timers in `afterEach`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 12dce08. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
metamask-ci
Bot
added
the
team-bots
|
Contributor
Builds ready [5d41c86]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 10 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
HowardBraham
approved these changes
Jul 30, 2026
metamaskbot
added
the
release-13.42.0
Contributor
|
No release label on PR. Adding release label release-13.42.0 on PR, as PR was cherry-picked in branch 13.42.0. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add timeout to the balance loading state
Description
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
UI-only loading-state timing in wallet overview; no auth, data, or
payment logic.
Overview
Wallet overview no longer keeps the balance skeleton up
indefinitely when the account has on-chain balance but aggregate fiat is
still $0 (e.g. rates still loading).
coin-overviewadds a 1.5s timer (ZERO_FIAT_BALANCE_DELAY_MS):the loading skeleton only applies while
shouldDelayZeroFiatBalanceistrue and the delay has not elapsed. After the timeout, the normal
balance UI is shown instead of staying on the skeleton. The timer
restarts when enabled networks change (stable key from
enabledNetworks).eth-overview.test.jsasserts the skeleton disappears after 1500ms(fake timers) and resets real timers in
afterEach.Reviewed by Cursor Bugbot for commit
12dce08. Bugbot is set up for automated
code reviews on this repo. Configure
here.