Skip to content

release(runway): cherry-pick fix: patch for missing slip44 entries in core client-utils cp-13.42.0 - #45039

Merged
vpintorico merged 1 commit into
release/13.42.0from
runway-cherry-pick-13.42.0-1785421986
Jul 30, 2026
Merged

vpintorico merged 1 commit into
release/13.42.0from
runway-cherry-pick-13.42.0-1785421986

Conversation

@runway-github

@runway-github runway-github Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

With issue #44993,
some token icons wouldn't appear for native sends. Ex: Monad, MegaETH.
Also on those networks, the corresponding activity entry would be
missing from the Token Page.

The issue came from missing slip44 entries in this file:
https://github.com/MetaMask/core/pull/9671/changes#diff-4d2d5a10eba039c36f21ec53cb573ad609cf4854cb1de5067a174d0140ace0dcL24-L35
(or the fact that existing slip44 entries could have been used instead)

The code with the missing entries is being removed/refactored. However
in the meantime the issue remains on the release/13.42.0 branch.

Solution: A patch to add the missing entries for cherry-picking on this
RC.

Changelog

CHANGELOG entry: patch for missing slip44 entries in core
client-utils

Related issues

Fixes: #44993

Manual testing steps

  1. From Monad and MegaETH, perform a native send (MON for Monad, ETH
    for MegaETH).
  2. Check the resulting Activity items:
  • Before: No icon + no item from MON/ETH token page
  • After: Icon appears and activity item visible from both general
    activity tab and token page

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Scoped dependency metadata patch for native asset mapping; no auth or
transaction logic changes, though incorrect slip44 values could affect
icon/activity display on those chains.

Overview
Adds a Yarn patch on @metamask/client-utils@1.2.0 so
nativeAssetsByCaipChainId in the CAIP helpers includes slip44 (and
symbol/decimals) for several EVM chains that were missing from the
published package—Monad (eip155:143), Hyperliquid
(eip155:999), and additional chain IDs 4326, 4663, and
5042.

package.json and yarn.lock now resolve @metamask/client-utils
through that patch instead of the plain npm version. This is a
short-term RC fix for missing native token icons and absent
token-page activity on native sends until the upstream core change
lands.

Reviewed by Cursor Bugbot for commit
e7a842e. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[ed7b8fb](https://github.com/MetaMask/metamask-extension/commit/ed7b8fbd539b63e42d1c8d8185423fbafbc6bdfa)

… core client-utils cp-13.42.0 (#45006)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

With issue #44993,
some token icons wouldn't appear for native sends. Ex: Monad, MegaETH.
Also on those networks, the corresponding activity entry would be
missing from the Token Page.

The issue came from missing slip44 entries in this file:
https://github.com/MetaMask/core/pull/9671/changes#diff-4d2d5a10eba039c36f21ec53cb573ad609cf4854cb1de5067a174d0140ace0dcL24-L35
(or the fact that existing slip44 entries could have been used instead)

The code with the missing entries is being removed/refactored. However
in the meantime the issue remains on the release/13.42.0 branch.

Solution: A patch to add the missing entries for cherry-picking on this
RC.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: [patch for missing slip44 entries in core
client-utils](d7e1645)

## **Related issues**

Fixes: #44993

## **Manual testing steps**

1. From Monad and MegaETH, perform a native send (`MON` for Monad, `ETH`
for MegaETH).
2. Check the resulting Activity items:
- Before: No icon + no item from MON/ETH token page
- After: Icon appears and activity item visible from both general
activity tab and token page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Scoped dependency metadata patch for native asset mapping; no auth or
transaction logic changes, though incorrect slip44 values could affect
icon/activity display on those chains.
> 
> **Overview**
> Adds a **Yarn patch** on `@metamask/client-utils@1.2.0` so
`nativeAssetsByCaipChainId` in the CAIP helpers includes **slip44** (and
symbol/decimals) for several EVM chains that were missing from the
published package—**Monad** (`eip155:143`), **Hyperliquid**
(`eip155:999`), and additional chain IDs **4326**, **4663**, and
**5042**.
> 
> `package.json` and `yarn.lock` now resolve `@metamask/client-utils`
through that patch instead of the plain npm version. This is a
**short-term RC fix** for missing native token icons and absent
token-page activity on native sends until the upstream core change
lands.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
e7a842e. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github
runway-github Bot requested a review from a team as a code owner July 30, 2026 14:33
@metamask-ci metamask-ci Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Jul 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud

Copy link
Copy Markdown

@metamask-ci

metamask-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
Builds ready [93a8f3f]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 9 warn · 🔴 0 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 30552283952 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ confirmTx/longTaskTotalDuration: -10%
  • ↓ confirmTx/tbt: -18%
  • ↑ bridgeUserActions/bridge_load_page: +11%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -23%
  • ↓ bridgeUserActions/longTaskCount: -44%
  • ↓ bridgeUserActions/longTaskTotalDuration: -36%
  • ↓ bridgeUserActions/tbt: -16%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +25%
  • ↑ startupStandardHome/fcp: +21%
  • ↓ startupPowerUserHome/uiStartup: -11%
  • ↑ startupPowerUserHome/initialActions: +11%
  • ↓ startupPowerUserHome/setupStore: -78%
  • ↑ startupPowerUserHome/numNetworkReqs: +13%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 2.6s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +18%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +10%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -45%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -92%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -80%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -22%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -21%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -24%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -30%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -30%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -30%
  • ↓ solanaAssetDetails/assetClickToPriceChart: -70%
  • ↓ solanaAssetDetails/longTaskCount: -100%
  • ↓ solanaAssetDetails/longTaskTotalDuration: -100%
  • ↓ solanaAssetDetails/longTaskMaxDuration: -100%
  • ↓ solanaAssetDetails/tbt: -100%
  • ↓ solanaAssetDetails/total: -70%
  • ↓ solanaAssetDetails/fcp: -12%
  • ↓ importSrpHome/loginToHomeScreen: -18%
  • ↓ importSrpHome/longTaskCount: -37%
  • ↓ importSrpHome/longTaskTotalDuration: -43%
  • ↓ importSrpHome/longTaskMaxDuration: -15%
  • ↓ importSrpHome/tbt: -43%
  • ↓ importSrpHome/inp: -17%
  • ↓ importSrpHome/cls: -15%
  • ↓ sendTransactions/openSendPageFromHome: -47%
  • ↓ sendTransactions/selectTokenToSendFormLoaded: -13%
  • ↓ sendTransactions/reviewTransactionToConfirmationPage: -99%
  • ↓ sendTransactions/longTaskCount: -100%
  • ↓ sendTransactions/longTaskTotalDuration: -100%
  • ↓ sendTransactions/longTaskMaxDuration: -100%
  • ↓ sendTransactions/tbt: -100%
  • ↓ sendTransactions/total: -97%
  • ↓ sendTransactions/inp: -37%
  • ↓ sendTransactions/fcp: -11%
  • ↓ sendTransactions/lcp: -37%
  • ↑ sendTransactions/cls: +171%
  • ↓ swap/openSwapPageFromHome: -38%
  • ↑ swap/fetchAndDisplaySwapQuotes: +84%
  • ↓ swap/longTaskCount: -100%
  • ↓ swap/longTaskTotalDuration: -100%
  • ↓ swap/longTaskMaxDuration: -100%
  • ↓ swap/tbt: -100%
  • ↑ swap/total: +85%
  • ↓ swap/inp: -21%
  • ↓ swap/lcp: -74%
  • ↓ swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 256ms
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 2.0s
  • 🟡 sendTransactions/LCP: p75 2.5s
  • 🔴 swap/INP: p75 800ms
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -25.95 KiB (-0.18%)
  • ui: 1.71 KiB (0.01%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 430 Bytes (0.02%)
  • zip: -6.11 MiB (-22.5%)

@vpintorico
vpintorico merged commit 7c8fdb7 into release/13.42.0 Jul 30, 2026
459 of 478 checks passed
@vpintorico
vpintorico deleted the runway-cherry-pick-13.42.0-1785421986 branch July 30, 2026 16:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 30, 2026
@metamaskbot metamaskbot added the release-13.42.0 Issue or pull request that will be included in release 13.42.0 label Jul 31, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.42.0 on PR, as PR was cherry-picked in branch 13.42.0.

This branch was previously deployed

1 inactive deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.42.0 Issue or pull request that will be included in release 13.42.0 risk:low team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants