Skip to content

bump: valibot to 1.4.2, body-parser to 1.20.6 and 2.3.0 - #44664

Merged
HowardBraham merged 2 commits into
mainfrom
audit
Jul 21, 2026
Merged

HowardBraham merged 2 commits into
mainfrom
audit

Conversation

@HowardBraham

@HowardBraham HowardBraham commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

This closes low-severity, non-blocking CVEs, but might as well.

  • valibot to 1.4.2
  • body-parser to 1.20.6 and 2.3.0

Changelog

CHANGELOG entry: null

Related issues

Closes: #43642
Closes: #44636


Note

Low Risk
Lockfile and LavaMoat policy-only dependency upgrades for dev/test HTTP parsing and schema validation; no wallet or auth logic changes.

Overview
Bumps valibot to 1.4.2 via a new package.json resolution, collapsing several pinned valibot versions in the lockfile to a single release.

Updates transitive body-parser (1.20.6 and 2.3.0), which pulls newer qs (6.15.3), side-channel, content-type, and type-is versions. LavaMoat webpack policies are updated so mockttp>express>qs may use es-define-property, matching qs’s new dependency graph.

Addresses low-severity CVEs (#43642, #44636); no application source changes.

Reviewed by Cursor Bugbot for commit f667d2b. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented Jul 21, 2026 •

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • content-type@2.0.0
  • type-is@2.1.0

View full report

@HowardBraham

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore npm/content-type@2.0.0

@HowardBraham

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamask-ci

metamask-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Policies updated.
👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.
🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv3/beta/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/flask/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes

@metamask-ci
metamask-ci Bot requested a review from a team as a code owner July 21, 2026 18:49
@metamask-ci

metamask-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (9 files, +9 -0)
  • 📁 lavamoat/
    • 📁 webpack/
      • 📁 build/
        • 📄 policy.json +1 -0
      • 📁 mv2/
        • 📁 beta/
          • 📄 policy.json +1 -0
        • 📁 experimental/
          • 📄 policy.json +1 -0
        • 📁 flask/
          • 📄 policy.json +1 -0
        • 📁 main/
          • 📄 policy.json +1 -0
      • 📁 mv3/
        • 📁 beta/
          • 📄 policy.json +1 -0
        • 📁 experimental/
          • 📄 policy.json +1 -0
        • 📁 flask/
          • 📄 policy.json +1 -0
        • 📁 main/
          • 📄 policy.json +1 -0

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@sonarqubecloud

Copy link
Copy Markdown

@HowardBraham

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore npm/type-is@2.1.0

@metamask-ci

metamask-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f667d2b]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 7 warn · 🔴 2 fail)

Baseline (latest main): 9b12c19 | Date: 7/21/2026 | Pipeline: 29858855029 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +15%
  • ↑ loadNewAccount/total: +15%
  • ↑ loadNewAccount/lcp: +21%
  • ↑ bridgeUserActions/bridge_load_page: +67%
  • ↑ bridgeUserActions/inp: +12%
  • ↑ loadNewAccount/load_new_account: +447%
  • ↑ loadNewAccount/total: +447%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -53%
  • ↑ loadNewAccount/lcp: +1093%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -26%
  • ↑ confirmTx/lcp: +1088%
  • ↑ bridgeUserActions/bridge_load_page: +119%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +33%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +11%
  • ↓ bridgeUserActions/inp: -25%
  • ↓ bridgeUserActions/fcp: -51%
  • ↑ bridgeUserActions/lcp: +1067%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/fcp: -13%
  • ↑ startupPowerUserHome/uiStartup: +24%
  • ↑ startupPowerUserHome/load: +31%
  • ↑ startupPowerUserHome/domContentLoaded: +31%
  • ↑ startupPowerUserHome/domInteractive: +54%
  • ↑ startupPowerUserHome/backgroundConnect: +30%
  • ↑ startupPowerUserHome/firstReactRender: +22%
  • ↑ startupPowerUserHome/loadScripts: +30%
  • ↑ startupPowerUserHome/setupStore: +32%
  • ↑ startupPowerUserHome/fcp: +60%
  • ↑ startupPowerUserHome/lcp: +25%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 216ms
  • 🟡 startupPowerUserHome/LCP: p75 4.0s
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -11%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -76%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -13%
  • ↓ onboardingImportWallet/longTaskCount: -90%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -97%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -75%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -15%
  • ↓ onboardingNewWallet/longTaskCount: -74%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -83%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -49%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -15%
  • ↓ solanaAssetDetails/assetClickToPriceChart: -65%
  • ↓ solanaAssetDetails/total: -65%
  • ↓ solanaAssetDetails/lcp: -10%
  • ↓ solanaAssetDetails/cls: -79%
  • ↓ importSrpHome/loginToHomeScreen: -29%
  • ↑ importSrpHome/openAccountMenuAfterLogin: +12%
  • ↓ importSrpHome/homeAfterImportWithNewWallet: -21%
  • ↓ importSrpHome/longTaskCount: -54%
  • ↓ importSrpHome/longTaskTotalDuration: -57%
  • ↓ importSrpHome/longTaskMaxDuration: -12%
  • ↓ importSrpHome/tbt: -54%
  • ↓ importSrpHome/total: -22%
  • ↓ importSrpHome/inp: -22%
  • ↓ importSrpHome/cls: -17%
  • ↓ sendTransactions/openSendPageFromHome: -29%
  • ↓ sendTransactions/selectTokenToSendFormLoaded: -20%
  • ↓ sendTransactions/reviewTransactionToConfirmationPage: -97%
  • ↓ sendTransactions/longTaskCount: -100%
  • ↓ sendTransactions/longTaskTotalDuration: -100%
  • ↓ sendTransactions/longTaskMaxDuration: -100%
  • ↓ sendTransactions/tbt: -100%
  • ↓ sendTransactions/total: -92%
  • ↓ sendTransactions/inp: -27%
  • ↓ sendTransactions/cls: -29%
  • ↓ swap/openSwapPageFromHome: -44%
  • ↑ swap/fetchAndDisplaySwapQuotes: +98%
  • ↓ swap/longTaskCount: -100%
  • ↓ swap/longTaskTotalDuration: -100%
  • ↓ swap/longTaskMaxDuration: -100%
  • ↓ swap/tbt: -100%
  • ↑ swap/total: +96%
  • ↓ swap/cls: -86%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 248ms
  • 🟡 assetDetails/FCP: p75 2.0s
  • 🟡 solanaAssetDetails/FCP: p75 2.0s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.54 KiB (0.01%)
  • ui: 1.3 KiB (0.01%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 120 Bytes (0.01%)
  • zip: 886 Bytes (0%)

@metamask-ci

metamask-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f667d2b]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 8 warn · 🔴 1 fail)

Baseline (latest main): 9b12c19 | Date: 7/21/2026 | Pipeline: 29858855029 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +15%
  • ↑ loadNewAccount/total: +15%
  • ↑ loadNewAccount/lcp: +21%
  • ↑ bridgeUserActions/bridge_load_page: +67%
  • ↑ bridgeUserActions/inp: +12%
  • ↑ loadNewAccount/load_new_account: +447%
  • ↑ loadNewAccount/total: +447%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -53%
  • ↑ loadNewAccount/lcp: +1093%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -26%
  • ↑ confirmTx/lcp: +1088%
  • ↑ bridgeUserActions/bridge_load_page: +119%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +33%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +11%
  • ↓ bridgeUserActions/inp: -25%
  • ↓ bridgeUserActions/fcp: -51%
  • ↑ bridgeUserActions/lcp: +1067%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/fcp: -13%
  • ↑ startupPowerUserHome/uiStartup: +24%
  • ↑ startupPowerUserHome/load: +31%
  • ↑ startupPowerUserHome/domContentLoaded: +31%
  • ↑ startupPowerUserHome/domInteractive: +54%
  • ↑ startupPowerUserHome/backgroundConnect: +30%
  • ↑ startupPowerUserHome/firstReactRender: +22%
  • ↑ startupPowerUserHome/loadScripts: +30%
  • ↑ startupPowerUserHome/setupStore: +32%
  • ↑ startupPowerUserHome/fcp: +60%
  • ↑ startupPowerUserHome/lcp: +25%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 216ms
  • 🟡 startupPowerUserHome/LCP: p75 4.0s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -21%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -79%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -25%
  • ↓ onboardingImportWallet/longTaskCount: -90%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -97%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -77%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -15%
  • ↓ onboardingNewWallet/longTaskCount: -74%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -83%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -49%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -15%
  • ↓ solanaAssetDetails/assetClickToPriceChart: -65%
  • ↓ solanaAssetDetails/total: -65%
  • ↓ solanaAssetDetails/lcp: -10%
  • ↓ solanaAssetDetails/cls: -79%
  • ↓ importSrpHome/loginToHomeScreen: -29%
  • ↑ importSrpHome/openAccountMenuAfterLogin: +12%
  • ↓ importSrpHome/homeAfterImportWithNewWallet: -21%
  • ↓ importSrpHome/longTaskCount: -54%
  • ↓ importSrpHome/longTaskTotalDuration: -57%
  • ↓ importSrpHome/longTaskMaxDuration: -12%
  • ↓ importSrpHome/tbt: -54%
  • ↓ importSrpHome/total: -22%
  • ↓ importSrpHome/inp: -22%
  • ↓ importSrpHome/cls: -17%
  • ↓ sendTransactions/openSendPageFromHome: -29%
  • ↓ sendTransactions/selectTokenToSendFormLoaded: -20%
  • ↓ sendTransactions/reviewTransactionToConfirmationPage: -97%
  • ↓ sendTransactions/longTaskCount: -100%
  • ↓ sendTransactions/longTaskTotalDuration: -100%
  • ↓ sendTransactions/longTaskMaxDuration: -100%
  • ↓ sendTransactions/tbt: -100%
  • ↓ sendTransactions/total: -92%
  • ↓ sendTransactions/inp: -27%
  • ↓ sendTransactions/cls: -29%
  • ↓ swap/openSwapPageFromHome: -44%
  • ↑ swap/fetchAndDisplaySwapQuotes: +98%
  • ↓ swap/longTaskCount: -100%
  • ↓ swap/longTaskTotalDuration: -100%
  • ↓ swap/longTaskMaxDuration: -100%
  • ↓ swap/tbt: -100%
  • ↑ swap/total: +96%
  • ↓ swap/cls: -86%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 248ms
  • 🟡 assetDetails/FCP: p75 2.0s
  • 🟡 solanaAssetDetails/FCP: p75 2.0s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.54 KiB (0.01%)
  • ui: 1.3 KiB (0.01%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 120 Bytes (0.01%)
  • zip: 886 Bytes (0%)

@HowardBraham
HowardBraham enabled auto-merge July 21, 2026 19:24

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MajorLift MajorLift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Policy changes are low-risk and contained to tests

@HowardBraham
HowardBraham added this pull request to the merge queue Jul 21, 2026
@HowardBraham HowardBraham added the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Jul 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2026
@HowardBraham
HowardBraham added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 6fb3e32 Jul 21, 2026
254 of 257 checks passed
@HowardBraham
HowardBraham deleted the audit branch July 21, 2026 20:55
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 21, 2026
@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Jul 21, 2026
@metamaskbot metamaskbot added release-13.42.0 Issue or pull request that will be included in release 13.42.0 release-13.41.0 Issue or pull request that will be included in release 13.41.0 and removed release-13.42.0 Issue or pull request that will be included in release 13.42.0 labels Jul 21, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

Missing release label release-13.41.0 on PR. Adding release label release-13.41.0 on PR and removing other release labels(release-13.42.0), as PR was cherry-picked in branch 13.41.0.

This branch was previously deployed

1 inactive deployment
pr-comment — f667d2bf Deployed Jul 21, 2026 by metamask-ci[bot] via Publish prerelease / Publish prerelease #153462
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.41.0 Issue or pull request that will be included in release 13.41.0 risk:low size-XS skip-release-validation team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Yarn Audit: new or newly blocking advisories on main (d9219d1be2) Yarn Audit: new or newly blocking advisories on main (bc93c982b4)

5 participants