Repository navigation
release(runway): cherry-pick fix(sentry): Resolve AggregatedBalanceSelector transaction volume spike by not passing trace into getAggregatedBalanceForAccount cp-13.40.0 - #44460
Merged
HowardBraham merged 1 commit intoJul 14, 2026
Conversation
…elector` transaction volume spike by not passing `trace` into `getAggregatedBalanceForAccount` cp-13.40.0 (#44449) ## Motivation `AggregatedBalanceSelector` accounts for [91% of all Sentry transaction roots](https://metamask.sentry.io/explore/traces/?aggregateField=%7B%22groupBy%22%3A%22transaction%22%7D&aggregateField=%7B%22yAxes%22%3A%5B%22count%28span.duration%29%22%5D%7D&environment=production&mode=aggregate&project=273505&sort=-count%28span.duration%29&statsPeriod=7d&query=is_transaction%3Atrue), and is growing as 13.38+ adoption climbs. Accepted transaction volume is holding at approximately 36M per week against a 3.2M per week pre-spike baseline. `ui/selectors/assets.ts` forwards `traceAsControllerCallback` into `getAggregatedBalanceForAccount` through the `assets.balance-utils` helpers. That function runs inside a Redux selector, so it recomputes per account group on every relevant state change and re-render. Each computation emits a forced transaction root (`span.op: custom`), with no sample gate. The same callback was removed from `assets-controller-init.ts` in #43213. That fix covered the controller entry point. The selector entry point, introduced by the same upstream changeset ([MetaMask/core#8310](MetaMask/core#8310)), was not covered, and reached production in 13.38.0 via #43635. `AggregatedBalanceSelector` is the only one of the seven traces added by core#8310 that is still emitting. The other six route through the controller callback removed in #43213 and are already at zero, so this call site closes core#8310 entirely. ## Description This commit removes `traceAsControllerCallback` from the two call sites in `ui/selectors/assets.ts` that forward it into the unified balance selectors, along with the now-unused import. The optional `trace` parameters are also removed from `aggregateGroupBalance`, `calculateBalanceForAllWallets`, and `calculateBalanceChangeForAccountGroup` in `ui/selectors/assets.balance-utils.ts`. Leaving them in place would allow the callback to be reintroduced by supplying a single argument, which is how it arrived in the first place. The test that asserted trace forwarding is inverted into a regression test asserting no trace is passed. ## Test plan - [x] `eslint` passes on all three touched files - [x] `tsc --noEmit` reports no errors in the touched files - [x] `ui/selectors/assets.test.ts` and `ui/selectors/assets.balance-utils.test.ts` pass (71 tests) - [ ] After release, [`AggregatedBalanceSelector` volume](https://metamask.sentry.io/explore/traces/?aggregateField=%7B%22groupBy%22%3A%22release%22%7D&aggregateField=%7B%22yAxes%22%3A%5B%22count%28span.duration%29%22%5D%7D&environment=production&mode=aggregate&project=273505&sort=-count%28span.duration%29&statsPeriod=30d&query=transaction%3AAggregatedBalanceSelector) drops to approximately zero on the fixed release ## Changelog CHANGELOG entry: null ## References Fixes #44447 Related: #43211, #43213, #43370, [MetaMask/core#8310](MetaMask/core#8310) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Observability-only change; balance math and selector inputs are unchanged aside from omitting the optional trace argument. > > **Overview** > Stops **Sentry transaction roots** from `AggregatedBalanceSelector` by no longer forwarding `traceAsControllerCallback` into unified wallet and account-group balance calculations. > > `ui/selectors/assets.ts` drops the trace import and stops passing a callback into `calculateBalanceForAllWallets` and `calculateBalanceChangeForAccountGroup` when assets-unify state is enabled. In `assets.balance-utils.ts`, optional `trace` parameters are removed end-to-end so `getAggregatedBalanceForAccount` is never given a trace callback from this Redux path (which recomputes per group on every relevant state change). The unit test now asserts the 7th argument to the aggregator stays **undefined** instead of expecting trace forwarding. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c781a10. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamask-ci
Bot
added
the
team-bots
HowardBraham
approved these changes
Jul 14, 2026
HowardBraham
enabled auto-merge (squash)
July 14, 2026 21:26
|
Contributor
Builds ready [30c61cf]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 9 warn · 🔴 0 fail)
Bundle sizes
|
metamaskbot
added
the
release-13.40.0
Contributor
|
No release label on PR. Adding release label release-13.40.0 on PR, as PR was cherry-picked in branch 13.40.0. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AggregatedBalanceSelectortransaction volume spike by not passingtraceintogetAggregatedBalanceForAccountcp-13.40.0 (fix(sentry): ResolveAggregatedBalanceSelectortransaction volume spike by not passingtraceintogetAggregatedBalanceForAccountcp-13.40.0 #44449)Motivation
AggregatedBalanceSelectoraccounts for 91% of all Sentry transactionroots,
and is growing as 13.38+ adoption climbs. Accepted transaction volume is
holding at approximately 36M per week against a 3.2M per week pre-spike
baseline.
ui/selectors/assets.tsforwardstraceAsControllerCallbackintogetAggregatedBalanceForAccountthrough theassets.balance-utilshelpers. That function runs inside a Redux selector, so it recomputes
per account group on every relevant state change and re-render. Each
computation emits a forced transaction root (
span.op: custom), with nosample gate.
The same callback was removed from
assets-controller-init.tsin#43213. That fix covered the controller entry point. The selector entry
point, introduced by the same upstream changeset
(MetaMask/core#8310), was
not covered, and reached production in 13.38.0 via #43635.
AggregatedBalanceSelectoris the only one of the seven traces added bycore#8310 that is still emitting. The other six route through the
controller callback removed in #43213 and are already at zero, so this
call site closes core#8310 entirely.
Description
This commit removes
traceAsControllerCallbackfrom the two call sitesin
ui/selectors/assets.tsthat forward it into the unified balanceselectors, along with the now-unused import.
The optional
traceparameters are also removed fromaggregateGroupBalance,calculateBalanceForAllWallets, andcalculateBalanceChangeForAccountGroupinui/selectors/assets.balance-utils.ts. Leaving them in place wouldallow the callback to be reintroduced by supplying a single argument,
which is how it arrived in the first place. The test that asserted trace
forwarding is inverted into a regression test asserting no trace is
passed.
Test plan
eslintpasses on all three touched filestsc --noEmitreports no errors in the touched filesui/selectors/assets.test.tsandui/selectors/assets.balance-utils.test.tspass (71 tests)AggregatedBalanceSelectorvolume
drops to approximately zero on the fixed release
Changelog
CHANGELOG entry: null
References
Fixes #44447
Related: #43211, #43213, #43370,
MetaMask/core#8310
Note
Low Risk
Observability-only change; balance math and selector inputs are
unchanged aside from omitting the optional trace argument.
Overview
Stops Sentry transaction roots from
AggregatedBalanceSelectorbyno longer forwarding
traceAsControllerCallbackinto unified wallet andaccount-group balance calculations.
ui/selectors/assets.tsdrops the trace import and stops passing acallback into
calculateBalanceForAllWalletsandcalculateBalanceChangeForAccountGroupwhen assets-unify state isenabled. In
assets.balance-utils.ts, optionaltraceparameters areremoved end-to-end so
getAggregatedBalanceForAccountis never given atrace callback from this Redux path (which recomputes per group on every
relevant state change). The unit test now asserts the 7th argument to
the aggregator stays undefined instead of expecting trace
forwarding.
Reviewed by Cursor Bugbot for commit
c781a10. Bugbot is set up for automated
code reviews on this repo. Configure
here.