chore: update CI workflows#37
Conversation
ulissesferreira
left a comment
ulissesferreira
left a comment
There was a problem hiding this comment.
This LGTM! I always wondered, why do we run two different Node versions on the CI's? Just to detect possible Node bugs?
@ulissesferreira how do you know that we run two different Node versions?) |
@ulissesferreira to be sure that the package is compatible with both Node versions |
| uses: ./.github/workflows/publish-release.yml | ||
| secrets: | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| LOG_LEVEL: ${{ secrets.LOG_LEVEL }} |
There was a problem hiding this comment.
what's the secrets' value for this one?
mikesposito
left a comment
mikesposito
left a comment
There was a problem hiding this comment.
We should update ./.github/workflows/lint-build-test.yml as well
@taran-a three actually |
hm, what we have to update there, please suggest ? |
Apologies, I was very vague. I'm referring to the build job in |
np) regarding variables - do you think we should use prod env here for testing and etc...? I checked with the source repo and we used fallback values there |
|
If they are empty on the source repo it's ok to leave them empty here. Also they likely would affect unit tests only, and they are all mocked. Should be safe to use fallbacks 👍 |
3 participants
Explanation
Add bitcoin env vars to publish release and preview workflows.
Add
environment: default-branchto publish-release job."LOG_LEVEL": "all"- is a constant for all preview builds.Remove
create-update-issuesworkflow and its script.References
Checklist