Initially run update-changelogs only for non-draft PRs#8750
Merged
Conversation
When an engineer opens a release PR, they may want to make additional changes to the release plan before they are ready to open the PR, and they may not want to populates dependency bump entries across changelogs right away. To account for this, this commit modifies the `update-changelogs` workflow so that the initial run only occurs if the PR is created in non-draft status or is taken out of draft otherwise.
Gudahtt
reviewed
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When an engineer opens a release PR, they may want to make additional changes to the release plan before they are ready to open the PR, and so they may not want to populate dependency bump entries across changelogs right away. To account for this, this commit modifies the
update-changelogsworkflow so that the initial run only occurs if the PR is created in non-draft status or is taken out of draft otherwise.References
Checklist
Note
Low Risk
Low risk workflow gating change; it only adjusts when the GitHub Actions job runs and does not affect production code paths.
Overview
Updates the
update-changelogsGitHub Actions workflow to not run automatically for draft PRs.The workflow now triggers on
pull_request_targetready_for_reviewand tightens theis-forkjob condition so the initial run only occurs when the PR is not a draft (while still allowing manual runs via@metamaskbot update-changelogscomments).Reviewed by Cursor Bugbot for commit f8a1fc0. Bugbot is set up for automated code reviews on this repo. Configure here.