Fix dev-only lint errors in universal-kyc packages

packages/kyc-controller/src/KycController.test.ts

@@ -541,7 +541,6 @@ describe('KycController', () => {
           },
         },
         async ({ controller, handlers }) => {
-          // @ts-expect-error T&C2 flags are required
           await controller.acceptTermsAndStartSession();
 
           expect(controller.state.phase).toBe('error');
@@ -4950,7 +4949,7 @@ function withController<ReturnValue>(
     parent: rootMessenger,
   });
   rootMessenger.delegate({
-    actions: SERVICE_ACTIONS,
+    actions: [...SERVICE_ACTIONS],
     events: [],
     messenger,
   });

packages/kyc-controller/src/KycService.test.ts

@@ -1,8 +1,8 @@
 import { Messenger, MOCK_ANY_NAMESPACE } from '@metamask/messenger';
 import type {
-  MockAnyNamespace,
   MessengerActions,
   MessengerEvents,
+  MockAnyNamespace,
 } from '@metamask/messenger';
 import nock, { cleanAll } from 'nock';
 
@@ -53,8 +53,7 @@ describe('KycService', () => {
         expect(
           () =>
             new KycService({
-              messenger:
-                messenger as unknown as MockAnyNamespace<KycServiceMessenger>,
+              messenger,
               baseUrl: MOCK_API_URL,
             }),
         ).toThrow(
@@ -558,7 +557,7 @@ describe('KycService', () => {
     });
 
     it('falls back to status-only HttpError when the body is not an object', async () => {
-      nock(MOCK_API_URL).get('/sessions/sid/status').reply(409, null);
+      nock(MOCK_API_URL).get('/sessions/sid/status').reply(409, 'null');
       const { service } = getService();
 
       await expect(

packages/kyc-controller/src/ukyc/testToken.test.ts

@@ -8,6 +8,7 @@ import {
   UKYC_KWIL_AUDIENCE,
 } from './constants.js';
 import { canonicalizeJson } from './storageAccessToken.js';
+import type { UkycStorageAccessTokenPayload } from './storageAccessToken.js';
 import { mintUkycTestToken } from './testToken.js';
 
 // A fixed 32-byte secret (all 0x42), as hex, so storage_id and keys are stable.
@@ -23,7 +24,7 @@ const EXPIRES_AT = new Date('2026-07-07T04:00:00Z');
  * @returns The decoded token envelope.
  */
 function decodeHeader(header: string): {
-  payload: Record<string, unknown>;
+  payload: UkycStorageAccessTokenPayload;
   signature: string;
 } {
   const [scheme, creds] = header.split(' ');

tsconfig.packages.json

@@ -15,6 +15,12 @@
       "@metamask/json-rpc-engine/v2": [
         "${configDir}/../json-rpc-engine/src/v2/index.ts"
       ],
+      "@metamask/profile-sync-controller/auth": [
+        "${configDir}/../profile-sync-controller/src/controllers/authentication/index.ts"
+      ],
+      "@metamask/profile-sync-controller/user-storage": [
+        "${configDir}../profile-sync-controller/src/controllers/user-storage/index.ts"
+      ],
       "@metamask/*": ["${configDir}/../*/src/index.ts"]
     }
   }