Skip to content

Fix dev-only lint errors in delegation packages - #10153

Merged
mcmire merged 1 commit into
mainfrom
fix-lint-errors/delegation-team
Sep 9, 2026
Merged

Fix dev-only lint errors in delegation packages#10153
mcmire merged 1 commit into
mainfrom
fix-lint-errors/delegation-team

Conversation

@mcmire

@mcmire mcmire commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Explanation

Currently, there are some type errors that exist in packages owned by @MetaMask/delegation. These type errors are not present in production code, so they are not flagged by yarn build, but they will be flagged soon by yarn lint:tsc, and so we need to fix them.

References

https://consensyssoftware.atlassian.net/browse/WPC-1275

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Test-only type annotations with no runtime or production code changes.

Overview
Addresses upcoming yarn lint:tsc failures in delegation-owned packages by tightening types in tests only—no production behavior changes.

In GatorPermissionsController.test.ts, mock delegation objects passed to encodeDelegations now assert delegate, delegator, and caveat args as Hex, matching stricter delegation typing.

In decodePermission/utils.test.ts, the all-zero expiry caveat terms fixture is annotated so it satisfies the Hex parameter expected by extractExpiryFromCaveatTerms.

Reviewed by Cursor Bugbot for commit b9888c9. Bugbot is set up for automated code reviews on this repo. Configure here.

Currently, there are some type errors that exist in delegation packages.
These type errors are not present in production code, so they are not
flagged by `yarn build`, but they _will_ be flagged soon by `yarn
lint:tsc`, and so we need to fix them.
@mcmire
mcmire force-pushed the fix-lint-errors/delegation-team branch from 43bcfe6 to b9888c9 Compare September 9, 2026 16:35
@mcmire
mcmire marked this pull request as ready for review September 9, 2026 17:00
@mcmire
mcmire requested a review from a team as a code owner September 9, 2026 17:00
@mcmire
mcmire deployed to default-branch September 9, 2026 17:00 — with GitHub Actions Active
@mcmire
mcmire added this pull request to the merge queue Sep 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 9, 2026
@mcmire
mcmire added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit 4dfae94 Sep 9, 2026
68 checks passed
@mcmire
mcmire deleted the fix-lint-errors/delegation-team branch September 9, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants