Fix dev-only lint errors in delegation packages - #10153
Merged
Merged
Conversation
Currently, there are some type errors that exist in delegation packages. These type errors are not present in production code, so they are not flagged by `yarn build`, but they _will_ be flagged soon by `yarn lint:tsc`, and so we need to fix them.
mcmire
force-pushed
the
fix-lint-errors/delegation-team
branch
from
September 9, 2026 16:35
43bcfe6 to
b9888c9
Compare
mcmire
marked this pull request as ready for review
September 9, 2026 17:00
V00D00-child
approved these changes
Sep 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, there are some type errors that exist in packages owned by
@MetaMask/delegation. These type errors are not present in production code, so they are not flagged byyarn build, but they will be flagged soon byyarn lint:tsc, and so we need to fix them.References
https://consensyssoftware.atlassian.net/browse/WPC-1275
Checklist
Note
Low Risk
Test-only type annotations with no runtime or production code changes.
Overview
Addresses upcoming
yarn lint:tscfailures in delegation-owned packages by tightening types in tests only—no production behavior changes.In
GatorPermissionsController.test.ts, mock delegation objects passed toencodeDelegationsnow assertdelegate,delegator, and caveatargsasHex, matching stricter delegation typing.In
decodePermission/utils.test.ts, the all-zero expiry caveattermsfixture is annotated so it satisfies theHexparameter expected byextractExpiryFromCaveatTerms.Reviewed by Cursor Bugbot for commit b9888c9. Bugbot is set up for automated code reviews on this repo. Configure here.