Skip to content

Create Create ADDLOGO-contract-map.json #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shahinmalekirad0-cell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create Create ADDLOGO-contract-map.json #1867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Create ADDLOGO-contract-map.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"0x25f2aabC1180DddAF5a859Be517dDA6dEC418773": {
"name": "Synth sETH",
"logo": "seth.png"

@cursor cursor Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referenced logo file missing

Medium Severity

The new entry sets logo to seth.png, but this commit does not add that file under images/ (or icons/), and no seth.png exists in the repository. The metadata points at an asset that is not present, so any workflow that resolves logos from this map would fail for this address.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit dc72d1e. Configure here.

}
}

@cursor cursor Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token map not published

Medium Severity

This commit adds a standalone JSON file, but index.js only exports contract-map.json, buildindex.js builds from metadata/, and package.json does not ship this filename. Nothing in the codebase reads Create ADDLOGO-contract-map.json, so the Synth sETH entry never reaches consumers of @metamask/contract-metadata.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit dc72d1e. Configure here.