fix(cli): support Windows project daemon launches - #48
Open
HowardBraham wants to merge 5 commits into
Open
HowardBraham wants to merge 5 commits into
HowardBraham wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Shell spawning breaks Windows project paths containing spaces, and a new test leaks environment state.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates daemon launching for Windows and clarifies local versus global CLI usage.
Changes:
- Adds Windows
.cmdruntime resolution and 30-second startup polling. - Resolves extension paths relative to the project root.
- Documents project-local and global invocation.
File summaries
| File | Description |
|---|---|
src/cli/mm.ts |
Updates daemon startup and path resolution. |
src/cli/mm.test.ts |
Tests runtime and extension-path behavior. |
README.md |
Clarifies CLI invocation methods. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
HowardBraham
force-pushed
the
windows-support
branch
3 times, most recently
from
September 18, 2026 02:23
e761f0e to
fe0a5f0
Compare
HowardBraham
force-pushed
the
windows-support
branch
from
September 18, 2026 02:37
fe0a5f0 to
d4e9ed7
Compare
There was a problem hiding this comment.
⚪ Unable to assess
Review details
Suppressed comments (1)
src/cli/mm.ts:1431
- This assumes every configured Windows TypeScript runner is a JavaScript entry point. A valid native runner shim (for example, one invoking a
.exe) will match this regex, but the returned command then asks Node to parse that executable and daemon startup fails. TheruntimeAPI is an arbitrary runner name, and the POSIX path preserves the shim's own interpreter semantics. Execute the.cmdshim through the Windows shell (and carry that requirement to all three spawn sites) rather than extracting an entry point and forcingprocess.execPath.
return {
command: process.execPath,
args: [path.win32.resolve(path.win32.dirname(binPath), '..', entryPoint)],
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
HowardBraham
force-pushed
the
windows-support
branch
3 times, most recently
from
September 18, 2026 03:00
e14b9fd to
550e3b0
Compare
HowardBraham
force-pushed
the
windows-support
branch
from
September 18, 2026 03:11
550e3b0 to
76571a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
mmCLI could not reliably launch a project's TypeScript daemon on Windows. The CLI bypasses the package manager when it starts the daemon, so it attempted to execute the POSIX-stylenode_modules/.bin/tsxshim instead of Windows'tsx.cmdlauncher. Relative extension paths also reached the consumer unchanged, allowing Chromium to resolve them from its executable directory rather than the target project.Cold Windows daemon startup could occasionally take longer than the CLI's 10-second readiness deadline. In addition, the docs did not clearly distinguish bare
mmusage from project-local package-manager invocation.Solution
.cmdon Windows and launch them with the required shell mode.runtime: node.mm serve.--extension-pathrelative to the selected project root while preserving absolute paths.mm, while project dependencies useyarn mm.Validation
yarn vitest src/cli/mm.test.ts --no-coverageyarn lint:eslintyarn buildclient-mcp-corewithyarn link--extension-path dist/chromedescribe-screen, an unlock interaction, andcleanup --shutdown.mm-serverand.mm-server.lockwere removedChangelog
Fixed Windows support for launching project-local
mmdaemons.