Skip to content

ci: reduce CI runtime and drop EOL Node.js versions #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hmalik88 wants to merge 14 commits into
base: main
Choose a base branch
from
Open

ci: reduce CI runtime and drop EOL Node.js versions #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
54741b9
ci: update actions/checkout from v4 to v5
hmalik88 Jul 9, 2026
1442b21
ci: remove prepare job and consolidate changelog validation into a si…
hmalik88 Jul 9, 2026
55bcad3
Merge remote-tracking branch 'origin/main' into hm/improve-ci
hmalik88 Jul 9, 2026
de40d89
ci: drop EOL Node.js versions and test on 22.x and 24.x
hmalik88 Jul 9, 2026
cdb91d1
chore: update changelogs for Node.js version drop
hmalik88 Jul 9, 2026
6bb3612
chore: fix changelog section order and prune unused ESLint suppressions
hmalik88 Jul 9, 2026
df6e332
chore: format eslint-suppressions.json
hmalik88 Jul 9, 2026
3f8aa08
ci: trigger run
hmalik88 Jul 9, 2026
2e378c6
ci: test on Node 22 only
hmalik88 Jul 9, 2026
2814385
ci: drop EOL Node.js versions and set minimum to 22
hmalik88 Jul 9, 2026
68ec507
ci: remove duplicate yarn constraints call from lint script
hmalik88 Jul 9, 2026
f4293a3
Merge remote-tracking branch 'origin/main' into hm/improve-ci
hmalik88 Jul 21, 2026
1465697
ci: add lint:ci script to avoid running constraints twice in CI
hmalik88 Jul 21, 2026
e0c7726
ci: run lint and build on Node 24 for faster tooling
hmalik88 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 9 additions & 34 deletions .github/workflows/build-lint-test.yml
View file
Open in desktop

@ccharly ccharly Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also do the same as this:

Looks like node 24 is much faster for some of those jobs

@hmalik88 hmalik88 Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e0c7726

Original file line number Diff line number Diff line change
Expand Up @@ -4,41 +4,21 @@ on:
workflow_call:

jobs:
prepare:
name: Prepare
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
outputs:
child-workspace-package-names: ${{ steps.workspace-package-names.outputs.child-workspace-package-names }}
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v1
with:
is-high-risk-environment: true
cache-node-modules: ${{ matrix.node-version == '22.x' }}
- name: Fetch workspace package names
id: workspace-package-names
run: |
echo "child-workspace-package-names=$(yarn workspaces list --no-private --json | jq --slurp --raw-output 'map(.name) | @json')" >> "$GITHUB_OUTPUT"
shell: bash

lint:
name: Lint (${{ matrix.script }})
runs-on: ubuntu-latest
needs: prepare
strategy:
matrix:
node-version: [22.x]
node-version: [24.x]
script:
- lint
- lint:ci
- constraints
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v1
with:
is-high-risk-environment: true
node-version: ${{ matrix.node-version }}
- name: Run yarn ${{ matrix.script }}
run: yarn "$SCRIPT"
env:
Expand All @@ -54,17 +34,13 @@ jobs:
validate-changelog:
name: Validate changelog
runs-on: ubuntu-latest
needs: prepare
strategy:
matrix:
node-version: [22.x]
package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v1
with:
is-high-risk-environment: true
- run: yarn workspace ${{ matrix.package-name }} changelog:validate
node-version: 24.x
- run: yarn workspaces foreach --all --no-private --parallel run changelog:validate
- name: Require clean working directory
shell: bash
run: |
Expand All @@ -76,15 +52,15 @@ jobs:
build:
name: Build
runs-on: ubuntu-latest
needs: prepare
strategy:
matrix:
node-version: [22.x]
node-version: [24.x]
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v1
with:
is-high-risk-environment: true
node-version: ${{ matrix.node-version }}
- run: yarn build
- name: Require clean working directory
shell: bash
Expand All @@ -97,16 +73,15 @@ jobs:
test:
name: Test
runs-on: ubuntu-latest
needs:
- prepare
strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [22.x]
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v1
with:
is-high-risk-environment: true
node-version: ${{ matrix.node-version }}
- run: yarn build
- run: yarn test
- name: Require clean working directory
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: Check workflows
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Download actionlint
id: download-actionlint
run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/7fdc9630cc360ea1a469eed64ac6d78caeda1234/scripts/download-actionlint.bash) 1.6.23
Expand Down
5 changes: 0 additions & 5 deletions eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@
"count": 1
}
},
"packages/keyring-eth-hd/src/hd-keyring.test.ts": {
"n/no-unsupported-features/node-builtins": {
"count": 1
}
},
"packages/keyring-eth-hd/src/hd-keyring.ts": {
"no-restricted-globals": {
"count": 18
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"create-release-branch": "create-release-branch --formatter oxfmt",
"foreach": "yarn workspaces foreach --all --parallel --verbose --exclude '@metamask/accounts-monorepo' run",
"lint": "yarn lint:eslint && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:readme",
Comment thread
ccharly marked this conversation as resolved.
"lint:ci": "yarn lint:eslint && yarn lint:misc --check && yarn lint:dependencies && yarn lint:readme",
"lint:dependencies": "yarn foreach depcheck && yarn dedupe --check",
"lint:dependencies:fix": "yarn foreach depcheck && yarn dedupe",
"lint:eslint": "yarn build:only-clean && yarn eslint",
Expand Down Expand Up @@ -91,7 +92,7 @@
"ws@7.4.6": "^7.5.10"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"packageManager": "yarn@4.16.0",
"lavamoat": {
Expand Down
4 changes: 4 additions & 0 deletions packages/account-api/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

## [1.1.0]

### Added
Expand Down
2 changes: 1 addition & 1 deletion packages/account-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"directory": "src"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
4 changes: 4 additions & 0 deletions packages/hw-wallet-sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

## [0.11.0]

### Added
Expand Down
2 changes: 1 addition & 1 deletion packages/hw-wallet-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"directory": "src"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
1 change: 1 addition & 0 deletions packages/keyring-api/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))
- Use `sensitive` struct for `privateKey` in `PrivateKeyExportedAccountStruct` ([#577](https://github.com/MetaMask/accounts/pull/577))
- This ensures the private key value is always redacted in case of validation errors.
- Bump `@metamask/superstruct` from `^3.3.0` to `^3.4.0` ([#577](https://github.com/MetaMask/accounts/pull/577))
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"directory": "src"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
2 changes: 2 additions & 0 deletions packages/keyring-eth-hd/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

- Bump `@metamask/keyring-sdk` from `^2.0.2` to `^2.2.0` ([#544](https://github.com/MetaMask/accounts/pull/544), [#546](https://github.com/MetaMask/accounts/pull/546), [#562](https://github.com/MetaMask/accounts/pull/562))
- Bump `@metamask/keyring-utils` from `^3.2.0` to `^3.3.1` ([#544](https://github.com/MetaMask/accounts/pull/544), [#546](https://github.com/MetaMask/accounts/pull/546))
- Bump `@metamask/keyring-api` from `^23.1.0` to `^23.5.0` ([#562](https://github.com/MetaMask/accounts/pull/562), [#569](https://github.com/MetaMask/accounts/pull/569), [#583](https://github.com/MetaMask/accounts/pull/583), [#587](https://github.com/MetaMask/accounts/pull/587))
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-eth-hd/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"typescript": "~5.3.3"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
4 changes: 4 additions & 0 deletions packages/keyring-eth-ledger-bridge/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

## [12.4.0]

### Added
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-eth-ledger-bridge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"typescript": "~5.3.3"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
2 changes: 2 additions & 0 deletions packages/keyring-eth-money/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

- Bump `@metamask/keyring-api` from `^23.1.0` to `^23.5.0` ([#562](https://github.com/MetaMask/accounts/pull/562), [#569](https://github.com/MetaMask/accounts/pull/569), [#583](https://github.com/MetaMask/accounts/pull/583), [#587](https://github.com/MetaMask/accounts/pull/587))
- Bump `@metamask/keyring-sdk` from `^2.1.1` to `^2.2.0` ([#562](https://github.com/MetaMask/accounts/pull/562))
- Bump `@metamask/superstruct` from `^3.3.0` to `^3.4.0` ([#577](https://github.com/MetaMask/accounts/pull/577))
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-eth-money/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"typescript": "~5.3.3"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
2 changes: 2 additions & 0 deletions packages/keyring-eth-qr/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

- Bump `@metamask/keyring-api` from `^23.1.0` to `^23.5.0` ([#562](https://github.com/MetaMask/accounts/pull/562), [#569](https://github.com/MetaMask/accounts/pull/569), [#583](https://github.com/MetaMask/accounts/pull/583), [#587](https://github.com/MetaMask/accounts/pull/587))
- Bump `@metamask/keyring-sdk` from `^2.1.1` to `^2.2.0` ([#562](https://github.com/MetaMask/accounts/pull/562))

Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-eth-qr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"typescript": "~5.3.3"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
2 changes: 2 additions & 0 deletions packages/keyring-eth-simple/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

- Bump `@metamask/keyring-sdk` from `^2.0.2` to `^2.2.0` ([#544](https://github.com/MetaMask/accounts/pull/544), [#546](https://github.com/MetaMask/accounts/pull/546), [#562](https://github.com/MetaMask/accounts/pull/562))
- Bump `@metamask/keyring-api` from `^23.1.0` to `^23.5.0` ([#562](https://github.com/MetaMask/accounts/pull/562), [#569](https://github.com/MetaMask/accounts/pull/569), [#583](https://github.com/MetaMask/accounts/pull/583), [#587](https://github.com/MetaMask/accounts/pull/587))

Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-eth-simple/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"typescript": "~5.3.3"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
1 change: 1 addition & 0 deletions packages/keyring-eth-trezor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))
- Bump `@metamask/hw-wallet-sdk` from `^0.10.0` to `^0.11.0` ([#599](https://github.com/MetaMask/accounts/pull/599))

## [10.1.1]
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-eth-trezor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"typescript": "~5.3.3"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"installConfig": {
"hoistingLimits": "workspaces"
Expand Down
2 changes: 2 additions & 0 deletions packages/keyring-internal-api/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

- Bump `@metamask/keyring-utils` from `^3.2.0` to `^3.3.1` ([#544](https://github.com/MetaMask/accounts/pull/544), [#546](https://github.com/MetaMask/accounts/pull/546))
- Bump `@metamask/keyring-api` from `^23.1.0` to `^23.5.0` ([#562](https://github.com/MetaMask/accounts/pull/562), [#569](https://github.com/MetaMask/accounts/pull/569), [#583](https://github.com/MetaMask/accounts/pull/583), [#587](https://github.com/MetaMask/accounts/pull/587))
- Bump `@metamask/superstruct` from `^3.3.0` to `^3.4.0` ([#577](https://github.com/MetaMask/accounts/pull/577))
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-internal-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"directory": "src"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
4 changes: 4 additions & 0 deletions packages/keyring-internal-snap-client/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

## [10.0.5]

### Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-internal-snap-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
"directory": "src"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
2 changes: 2 additions & 0 deletions packages/keyring-sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))

- Bump `@metamask/keyring-api` from `^23.2.0` to `^23.5.0` ([#569](https://github.com/MetaMask/accounts/pull/569), [#583](https://github.com/MetaMask/accounts/pull/583), [#587](https://github.com/MetaMask/accounts/pull/587))
- Bump `@metamask/superstruct` from `^3.3.0` to `^3.4.0` ([#577](https://github.com/MetaMask/accounts/pull/577))

Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"directory": "src"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
1 change: 1 addition & 0 deletions packages/keyring-snap-bridge/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))
- Bump `@metamask/superstruct` from `^3.3.0` to `^3.4.0` ([#577](https://github.com/MetaMask/accounts/pull/577))

## [23.0.1]
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-snap-bridge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"directory": "src"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
1 change: 1 addition & 0 deletions packages/keyring-snap-client/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Drop support for Node.js v18 and v20; minimum version is now v22 ([#593](https://github.com/MetaMask/accounts/pull/593))
- Bump `@metamask/superstruct` from `^3.3.0` to `^3.4.0` ([#577](https://github.com/MetaMask/accounts/pull/577))

## [9.2.0]
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-snap-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"directory": "src"
},
"engines": {
"node": "^18.18 || >=20"
"node": ">=22"
},
"lavamoat": {
"allowScripts": {
Expand Down
Loading
Loading