Add issueTimestamp and acquisitionTimestamp#117
Conversation
…s. Misc refactoring & add tests
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9f39ca607
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (signature.length == 0) revert ICyberCertPrinter.SignatureRequired(); | ||
| CyberCertPrinterStorage.cyberCertStorage().issuerSignatures[tokenId].push(signature); | ||
| emit CertificateSigned(tokenId, signature); | ||
| emit ICyberCertPrinter.CertificateSigned(tokenId, signature); |
There was a problem hiding this comment.
After this refactor CyberCertPrinter emits events declared only on ICyberCertPrinter, but the implementation contract neither declares nor inherits that interface, so the generated CyberCertPrinter artifact/ABI will no longer include these emitted events. In deployments or indexers that instantiate the printer from its implementation ABI, events such as CertificateSigned, CyberCertTransfer, UnitsReservedUpdated, and LegalOwnerChanged disappear from the interface even though logs are still emitted, breaking log decoding/subscriptions; keep the declarations on the contract or inherit an interface whose event ABI is meant to be exposed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
all events are defined in ICyberCertPrinter.sol instead, so offchain ABI will be provided from there
…acquisition-timestamps
…terestExtension type identifier for reuse
1 participant
Added
issueTimestampandacquisitionTimestampas base propertiesUpdated
HoldingPeriodConditionandRegSDistributionComplianceConditionper above property changesIssuanceManagersecondary transfer behavior and removed auto-merge feature (to avoid conflicting cert properties such asacquisitionTimestamp)