deal manager secondary trades

[Detoo]

TODO

• Contract size too large. Will move stuff to storage
• Merge new CyberCertPrinter functions
• Add indexer tests for cert transfer history
• Review against specs and add more tests
• All interfaces are placeholders for unit-test purposes (i.e. method names are not final)

Added

• Secondary Trading arm of DealManager
• Partial fills for Secondary Trading
• Indexer tests for Secondary Trading

Updated

• Spec: decided not to extend LexScroWLite with secondary trade logic because the overlaps between primary and secondary trades turns out to be too small to worth sharing the same base contract

  • The underlying NFT pathways are very different. If we implement both inside LexScroWLite, they will be mostly non-overlapping if...else branches. Why risking re-audit LexScroWLite if most of its codes are re-written?
  • However, secondary trading logic will still live on DealManager through a dedicated storage SecondaryTradeStorage; this way we don't need to deploy a new manager (and its factory)

• Refactoring: convert LexScroWLite into a pure library by merging it with LexScrowStorage. This is for reducing DealManager contract size. No behavioral changes, no ABI changes, no migration needed

  • no migration needed because LexScroWLite alone is stateless: all its app data is already stored in LexScrowStorage and will continue be so after the refactoring

[merisman]

Reviewed, submitted 4 issues via dm. Going to merge and fix on feat/legion branch.