cmake configure test only when BUILD_TESTING=ON - #249
Merged
Conversation
Determine whether to build tests by following the CTest module BUILD_TESTING option.
Matt Shin (matthewrmshin)
requested a review
from Yaswant Pradhan (yaswant)
as a code owner
September 22, 2025 14:42
Collaborator
|
Code looks good. Do you know why the CI is failing? Do we have a suitable fix? Should we try using the latest CI containers again? |
Collaborator
Author
|
Looks like the same failure as another PR. |
David Davies (DJDavies2)
approved these changes
Sep 22, 2025
Michael Cooke (mikecooke77)
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Determine whether to build tests by following the CTest module BUILD_TESTING option.