Skip to content

Add cx , varobs namelists for EPSMWS obsgroup - #246

Merged
Chris Thomas (ctgh) merged 5 commits into
developfrom
feature/addepsmwsnl
Aug 20, 2025
Merged

Add cx , varobs namelists for EPSMWS obsgroup#246
Chris Thomas (ctgh) merged 5 commits into
developfrom
feature/addepsmwsnl

Conversation

@brettcandy

Copy link
Copy Markdown
Contributor

This change adds namelist files specifying cx and varobs fields for obsgroup EPSMWS (mw sounder on MetopSG). These are identical to SternaMWS in terms of content. I also noticed that the specification for default varobs fields for both Sterna and EPS were incorrect - the bias predictors are specified twice.

@brettcandy

Copy link
Copy Markdown
Contributor Author

Tests in sith

I have built the code on the EX matchines and have run a single cylc of my sith branch for EPSMWS. Change performs as expected. see output here

@brettcandy
Brett Candy (brettcandy) marked this pull request as ready for review August 7, 2025 14:33
@brettcandy

Copy link
Copy Markdown
Contributor Author

This is now ready for review.

@ctgh Chris Thomas (ctgh) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Would you be able to add a CX writer test too, please?

Comment thread deps/ops/stubs/OpsMod_Varobs/Ops_GetDefaultVarfields.inc
@brettcandy

Copy link
Copy Markdown
Contributor Author

I have added ctests for cxwriter for SternaMWS and EPSMWS in changesets 333dce2 and 8bb0c4b

@brettcandy

Copy link
Copy Markdown
Contributor Author

The additional ctests are ready now and work - do you require anything else?
thanks

@ctgh Chris Thomas (ctgh) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the CX writer test. Can you please add a 'ready to merge' label and also retrigger the CI? It looks like there was a transient problem which should disappear if it is rerun.

@brettcandy

Copy link
Copy Markdown
Contributor Author

Any idea why the CI tests are failing Matt Shin (@matthewrmshin) ? i have retriggered several times over several days

@mikecooke77

Michael Cooke (mikecooke77) commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

Any idea why the CI tests are failing Matt Shin (@matthewrmshin) ? i have retriggered several times over several days

I do wonder if we should just use our own CI rather than trying to use there image for this testing. opsinputs is only ever going to be used in our environment.

@ctgh

Copy link
Copy Markdown
Collaborator

Michael Cooke (@mikecooke77) Shall we go ahead and merge this, given it passes the tests on our local system?

@brettcandy

Copy link
Copy Markdown
Contributor Author

Michael Cooke (@mikecooke77) Shall we go ahead and merge this, given it passes the tests on our local system?

yes or advise me what to do to get CI working please

@brettcandy

Copy link
Copy Markdown
Contributor Author

bump - any progress here ?

@ctgh

Copy link
Copy Markdown
Collaborator

I'll just bypass the rules. It shouldn't affect our internal CI, but I will keep an eye on the nightlies.

@ctgh
Chris Thomas (ctgh) merged commit 6c087cd into develop Aug 20, 2025
4 of 6 checks passed
@ctgh
Chris Thomas (ctgh) deleted the feature/addepsmwsnl branch August 20, 2025 15:16
@brettcandy

Copy link
Copy Markdown
Contributor Author

grazias

@matthewrmshin

Copy link
Copy Markdown
Collaborator

Most likely because CI image is old. Just checked. The image jcsda/docker-clang-mpich-dev:latest has eckit 1.24.5 and the recent change to ioda requires a more up-to-date version of eckit.

@ctgh

Copy link
Copy Markdown
Collaborator

Matt Shin (@matthewrmshin) Thanks for looking into that. Is there anything that can be done from our side to get that up to date?

@matthewrmshin

Copy link
Copy Markdown
Collaborator

Chris Thomas (@ctgh) Yes, (and bearing in mind that this is a public repo like orca-jedi), we can do what orca-jedi is doing and build our own container image for CI purpose and storing the image under GitHub container registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants