Add required CX fields for screen obs - #196
Conversation
Chris Thomas (ctgh)
added
the
coordinate merge
Mike Thurlow (mikethurlow)
left a comment
Mike Thurlow (mikethurlow)
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks Chris
Lee Hawkness-Smith (ldhawknesssmith)
left a comment
Lee Hawkness-Smith (ldhawknesssmith)
left a comment
There was a problem hiding this comment.
All looks ok, thanks Chris
JoanneAWaller
left a comment
JoanneAWaller
left a comment
There was a problem hiding this comment.
Looks good. Thanks Chris.
|
Thanks for your reviews! I am shortly going to add corresponding PRs in sith and jjdocs. |
Michael Cooke (mikecooke77)
left a comment
Michael Cooke (mikecooke77)
left a comment
There was a problem hiding this comment.
Looks good to me. My only question is whether there needs to be individual tests for each cx variable? I think in general there is.
|
Michael Cooke (@mikecooke77) Good idea - now added in e511cb8 |
|
Chris Thomas (@ctgh) if you are happy for the merge please add the flag and I will commit |
Chris Thomas (ctgh)
added
ready to merge
and removed
coordinate merge
|
Michael Cooke (@mikecooke77) Thanks, now done. This PR can go in before the ones in sith and jjdocs because there is no KGO testing for screen. |
6 participants
Add required CX fields for screen obs.
Note that, internally, screen obs are referred to as
Surface. Therefore a new CX namelist has been created: etc/global/cx/screen/Surface.nlTo be merged with:
ctest output: http://fcm1/cylc-review/taskjobs/chthomas/?suite=opsinputs-screenfields