Skip to content

Update yaml files with the new syntax for where variable is_defined / is_not_defined - #194

Merged
Chris Thomas (ctgh) merged 1 commit into
developfrom
feature/refactor_where_params
Jan 30, 2024
Merged

Update yaml files with the new syntax for where variable is_defined / is_not_defined#194
Chris Thomas (ctgh) merged 1 commit into
developfrom
feature/refactor_where_params

Conversation

@james-cotton

@james-cotton James Cotton (james-cotton) commented Jan 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Refactors yamls in processWhere for is_defined and is_not_defined

Issue(s) addressed

Resolves #193

Impact

Requires changes in yamls that use filters with where statement:
is_defined: -> changed to value: is_valid
is_not_defined: -> changed to value: is_not_valid

@james-cotton James Cotton (james-cotton) added coordinate merge Pull requests that require coordination with pull requests in other repos do not merge labels Jan 22, 2024
ctgh
Chris Thomas (ctgh) approved these changes Jan 22, 2024
View reviewed changes

@ctgh Chris Thomas (ctgh) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

mikecooke77
Michael Cooke (mikecooke77) approved these changes Jan 25, 2024
View reviewed changes

@mikecooke77 Michael Cooke (mikecooke77) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this change. Should we run the kgo testing with all repos updated?

twsearle
Toby Searle (twsearle) approved these changes Jan 25, 2024
View reviewed changes

@twsearle Toby Searle (twsearle) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ctgh

Chris Thomas (ctgh) commented Jan 25, 2024

Copy link
Copy Markdown
Collaborator

I'm happy with this change. Should we run the kgo testing with all repos updated?

Do you mean for sith, or all of the mo-bundle unit tests?

@mikecooke77

Michael Cooke (mikecooke77) commented Jan 25, 2024

Copy link
Copy Markdown
Collaborator

I'm happy with this change. Should we run the kgo testing with all repos updated?

Do you mean for sith, or all of the mo-bundle unit tests?

Probably kgo and mo-bundle.

@ctgh

Chris Thomas (ctgh) commented Jan 25, 2024

Copy link
Copy Markdown
Collaborator

I'm happy with this change. Should we run the kgo testing with all repos updated?

Do you mean for sith, or all of the mo-bundle unit tests?

Probably kgo and mo-bundle.

Sure, I will update my build with this branch and run all of the unit tests. I already ran the KGO tests in the sith PR, but I can do that again with the updated build for completeness.

@ctgh

Chris Thomas (ctgh) commented Jan 25, 2024

Copy link
Copy Markdown
Collaborator

Full ctest output is here: http://fcm1/cylc-review/taskjobs/chthomas/?suite=refactor_where_params
Everything looks good to me.

@ctgh
Chris Thomas (ctgh) merged commit 96ccc7f into develop Jan 30, 2024
@ctgh
Chris Thomas (ctgh) deleted the feature/refactor_where_params branch January 30, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twsearle Toby Searle (twsearle) twsearle approved these changes
@ctgh Chris Thomas (ctgh) ctgh approved these changes
@mikecooke77 Michael Cooke (mikecooke77) mikecooke77 approved these changes

Assignees

@james-cotton James Cotton (james-cotton)

Labels

coordinate merge Pull requests that require coordination with pull requests in other repos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adapt to changes to refactor processWhere yaml

5 participants

@james-cotton @ctgh @mikecooke77 @twsearle @matthewrmshin