Add a smal change to bugfix map chans for seviri to work correctly. - #192
Merged
Conversation
Owen Lewis (orlewis)
requested review from
PJLevensMO,
Chris Thomas (ctgh) and
Michael Cooke (mikecooke77)
December 19, 2023 14:59
Chris Thomas (ctgh)
approved these changes
Dec 19, 2023
Chris Thomas (ctgh)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks like a straightforward change.
PJLevensMO
approved these changes
Dec 19, 2023
PJLevensMO
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this fix. I have tested this change for SEVIRI, and it fixes the problem with channel 6. I have also checked the effect on the other Geo instruments (ABI and AHI) and they remain the same, as expected.
Contributor
Author
|
KGO have been run successfully http://fcm1/cylc-review/taskjobs/olewis/?suite=sith_kgo_231219 Geos can also be seen here: SEVIRI: https://www-nwp/~plevens/ngops_boitenoire/sith_SEVIRI_test/seviriclr/glu_20210701T1200Z/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When final testing was carried out on Seviri the VAR statistics did not look correct. This problem was only happening for channel 6.
The bug comes about from seviri having 6 channels read in but only 5 output to the varobs. This meant that a loop which cycled on the number of channels went round 6 times. A variable called arrayindex was used to assign where in an array to palce a value, this is initially set as the loop number. For seviri the logic follows a route where the arrayindex was updated to be the actual channel number, however on the final loop 6 the if logic prevents the arrayindex being reallocated and so channel 6 gets filled with the final channel 11 observations.
This is fixed by setting an exit on the loop if the condition is not met.