Skip to content

Add a smal change to bugfix map chans for seviri to work correctly. - #192

Merged
Chris Thomas (ctgh) merged 1 commit into
developfrom
bugfix/seviri_mapchans
Dec 19, 2023
Merged

Add a smal change to bugfix map chans for seviri to work correctly.#192
Chris Thomas (ctgh) merged 1 commit into
developfrom
bugfix/seviri_mapchans

Conversation

@orlewis

Copy link
Copy Markdown
Contributor

When final testing was carried out on Seviri the VAR statistics did not look correct. This problem was only happening for channel 6.

The bug comes about from seviri having 6 channels read in but only 5 output to the varobs. This meant that a loop which cycled on the number of channels went round 6 times. A variable called arrayindex was used to assign where in an array to palce a value, this is initially set as the loop number. For seviri the logic follows a route where the arrayindex was updated to be the actual channel number, however on the final loop 6 the if logic prevents the arrayindex being reallocated and so channel 6 gets filled with the final channel 11 observations.

This is fixed by setting an exit on the loop if the condition is not met.

@ctgh Chris Thomas (ctgh) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like a straightforward change.

@PJLevensMO PJLevensMO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this fix. I have tested this change for SEVIRI, and it fixes the problem with channel 6. I have also checked the effect on the other Geo instruments (ABI and AHI) and they remain the same, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants