Unrotate 10m winds - #190
Merged
Merged
Conversation
James Cotton (james-cotton)
requested review from
Chris Thomas (ctgh),
Michael Cooke (mikecooke77) and
Stuart Newman (smnewman)
November 27, 2023 16:40
Chris Thomas (ctgh)
approved these changes
Nov 27, 2023
Chris Thomas (ctgh)
left a comment
Chris Thomas (ctgh)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks for adding this. The use of the UpperWinds and SurfaceWinds logicals adds flexibility. The new ctest is behaving as expected.
Stuart Newman (smnewman)
approved these changes
Nov 29, 2023
Stuart Newman (smnewman)
left a comment
Stuart Newman (smnewman)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me James Cotton (@james-cotton), nothing to add
Collaborator
|
James Cotton (@james-cotton) if this is ready please add the ready to merge flag and I'll merge |
Collaborator
|
Also is it worth running any of the kgo's or not? |
Contributor
Author
|
Michael Cooke (@mikecooke77) I have just run the ukv KGO with this build and the sonde output is unchanged I have also verified the Scatwind output is unrotated as expected. |
Contributor
Author
|
Are you ok to merge this? Michael Cooke (@mikecooke77) Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the UKV, we need to unrotate the wind components u10 and v10 before writing out the CX columns, as was done for u and v in #133 .
Fixes #140
n.b. Changes are easier to view if whitespace changes are hidden.