Update time window configuration - #189
Merged
Merged
Conversation
Chris Thomas (ctgh)
added
the
coordinate merge
Chris Thomas (ctgh)
requested review from
James Cotton (james-cotton) and
Michael Cooke (mikecooke77)
November 21, 2023 13:29
James Cotton (james-cotton)
approved these changes
Nov 24, 2023
James Cotton (james-cotton)
left a comment
James Cotton (james-cotton)
left a comment
Contributor
There was a problem hiding this comment.
I can't see any issues with the conversion, and looks straightforward as no window shifts to deal with here. Thanks for your efforts to implement the new configuration!
Michael Cooke (mikecooke77)
approved these changes
Dec 7, 2023
Michael Cooke (mikecooke77)
left a comment
Michael Cooke (mikecooke77)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for all this work on window shift a truly mammoth task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the configuration of the assimilation time window.
Yaml changes
The new yaml configuration is as follows:
All yaml files were changed using the script shown in the accompanying oops PR.
Issue
Resolves #188
Dependencies
Coordinate merge required