add clang container to CI workflow - #184
Merged
Merged
Conversation
Yaswant Pradhan (yaswant)
added
enhancement
Matt Shin (matthewrmshin)
approved these changes
Oct 3, 2023
Matt Shin (matthewrmshin)
left a comment
Matt Shin (matthewrmshin)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. CI output looks sensible.
Michael Cooke (mikecooke77)
approved these changes
Oct 3, 2023
Chris Thomas (ctgh)
approved these changes
Oct 3, 2023
Chris Thomas (ctgh)
left a comment
Chris Thomas (ctgh)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding this. I haven't followed all of the syntax but the output looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use JCSDA clang continer in CI workflow