Install etc/{global,ukv} on package install - #177
Merged
Conversation
Install contents in etc/ on package install. Copy instead of symlink etc/ contents to binary directory, as disk usage of contents is actually quite small. This allows binary directory to become more independent of the source directory after successful build.
Matt Shin (matthewrmshin)
requested review from
David Davies (DJDavies2),
Michael Cooke (mikecooke77) and
Yaswant Pradhan (yaswant)
August 2, 2023 13:26
Michael Cooke (mikecooke77)
approved these changes
Aug 2, 2023
Yaswant Pradhan (yaswant)
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install contents in
etc/on package install (i.e., when we runcmake --installormake installafter a successful build).Also modify the existing logic to copy instead of symlink
etc/contents to binary/build directory, as disk usage of contents is actually quite small, so there is really very little difference whether the files are symbolically linked or installed.Relates to MetOffice/mo-bundle#221, (which adds the functionality to install JEDI applications to an alternate location after a successful build).